1058543 - [e10s] Page Info is broken

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Alice0775 White]

Page Info is broken.

General pane does not show actual data.
Media pane does not show.
Permissions only show Activate plugins.
Security pane does not show actual data. Buttons do not work.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-page-info

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8480898 [details] [diff] [review]
fix-page-info

Review of attachment 8480898 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/pageinfo/pageInfo.js
@@ +322,5 @@
>               window.arguments.length >= 1 &&
>               window.arguments[0];
>  
>    if (!args || !args.doc) {
> +    gWindow = window.opener.gBrowser.selectedBrowser.contentWindowAsCPOW;

Guh, PageInfo is so slow - we recurse through all of the frames in the child via CPOW here: http://hg.mozilla.org/mozilla-central/file/d697d649c765/browser/base/content/pageinfo/pageInfo.js#l552.

This whole thing is begging for messaging, but yes, this will do as a short-term fix.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/debf4d0152b2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/debf4d0152b2

Comment 6

[Petruta Horea [:phorea], Desktop QA]

Verified the "More information" panel on normal and secured pages using Nightly 35.0a1 with e10s enabled, Win 7 64-bit.