1058639 - [sms] '+' icon vertically misaligned in composer view

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Wilson Page [:wilsonpage]]

Attachment: icon-misaligned.png

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8479089 [details] [review]
pull-request (master)

Hey Wilson!

Thanks for the fix, looks good on Flame, but doesn't on Hamachin/Buri. Not sure what is the reason though....

Could you please check?

Thanks!

Comment 3

[Wilson Page [:wilsonpage]]

Attachment: hamachi-before-patch.png

Comment 4

[Wilson Page [:wilsonpage]]

Attachment: hamachi-after-patch.png

Comment 5

[Wilson Page [:wilsonpage]]

azasypkin: Seems OK on my Hamachi. What are you seeing?

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to Wilson Page [:wilsonpage] from comment #5)
> azasypkin: Seems OK on my Hamachi. What are you seeing?

Hmm, on my Hamachi "+" has correct position initially, but with patch it's obviously misaligned :) Ok, maybe something wrong with my Hamachi, let me try to find one more Hamachi tomorrow and if it's fine we'll go ahead with your patch :)

Comment 7

[Oleg Zasypkin [:azasypkin]]

Hey Wilson,

We've checked this patch with Steve's devices (Flame and Hamachi) and saw another results: "+" is fine initially on Flame, but a bit high for Hamachi, so patch fixes problem on Hamachi, but makes "+" misaligned on Steve's Flame. It's weird as we both have different initial state. Maybe the safest option would be to just use image instead. 

What do you think?

Fang, could you please help us with 1/1.5/2/2.25 image assets for the "+" (add contact) button so that it looks the same on all devices?

Thanks!

Comment 8

[Fang Shih [:fang]]

Attachment: plus_assets.zip

Hi Oleg,
Here are the image assets for the "+", Thanks! :)

Comment 9

[Julien Wajsberg [:julienw]]

About the "+" issue, can you all check you have the correct fonts?

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8479089 [details] [review]
pull-request (master)

Update the patch to use official gaia-icons 'add' icon.

Comment 11

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 12

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8518195 [details] [review]
pull-request (master)

Looks good to me, thanks Wilson!

But since size of "+" has changed a bit, let's reconfirm with Fang and we're good to go.

Comment 13

[Oleg Zasypkin [:azasypkin]]

Attachment: add_contact_plus_icon.png

Hey Fang,

Size of "+" ("add contact" button next to the recipients input) is going to change a bit in this patch. Could you please confirm that it's still ok for you?

Thanks!

Comment 14

[Fang Shih [:fang]]

Hey Oleg, 

Is there any reason we make them in different size in this patch? The only thing I concern here is we also want to make sure the + button is in the same size with Email's "+". Is there any way we can know we are using the same size here? Or anything I can provide, please let me know. Thanks!

Comment 15

[Oleg Zasypkin [:azasypkin]]

Redirecting question to Wilson :)

Comment 16

[Julien Wajsberg [:julienw]]

Note that Wilson is in PTO :)

Comment 17

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #16)
> Note that Wilson is in PTO :)

Thanks for the note! I guess we can wait as it isn't that critical :)

Comment 18

[Wilson Page [:wilsonpage]]

Apologies, I will make sure size is exactly same as before patch, and then land.

Comment 19

[Wilson Page [:wilsonpage]]

For some reason, I'm not seeing the misalignment anymore on master! I'm going to close this. Will re-open if it returns.

Comment 20

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8519968 [details]
add_contact_plus_icon.png

Okay, removing ui-review request then