[sms] '+' icon vertically misaligned in composer view

RESOLVED WORKSFORME

Status

RESOLVED WORKSFORME
4 years ago
4 years ago

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8479087 [details]
icon-misaligned.png
(Assignee)

Comment 1

4 years ago
Created attachment 8479089 [details] [review]
pull-request (master)
Attachment #8479089 - Flags: review?(azasypkin)
Comment on attachment 8479089 [details] [review]
pull-request (master)

Hey Wilson!

Thanks for the fix, looks good on Flame, but doesn't on Hamachin/Buri. Not sure what is the reason though....

Could you please check?

Thanks!
Attachment #8479089 - Flags: review?(azasypkin)
(Assignee)

Comment 3

4 years ago
Created attachment 8487287 [details]
hamachi-before-patch.png
Attachment #8487287 - Flags: feedback?(azasypkin)
(Assignee)

Comment 4

4 years ago
Created attachment 8487288 [details]
hamachi-after-patch.png
Attachment #8487288 - Flags: feedback?(azasypkin)
(Assignee)

Comment 5

4 years ago
azasypkin: Seems OK on my Hamachi. What are you seeing?
Attachment #8487288 - Flags: feedback?(azasypkin) → feedback+
Attachment #8487287 - Flags: feedback?(azasypkin)
(In reply to Wilson Page [:wilsonpage] from comment #5)
> azasypkin: Seems OK on my Hamachi. What are you seeing?

Hmm, on my Hamachi "+" has correct position initially, but with patch it's obviously misaligned :) Ok, maybe something wrong with my Hamachi, let me try to find one more Hamachi tomorrow and if it's fine we'll go ahead with your patch :)
Hey Wilson,

We've checked this patch with Steve's devices (Flame and Hamachi) and saw another results: "+" is fine initially on Flame, but a bit high for Hamachi, so patch fixes problem on Hamachi, but makes "+" misaligned on Steve's Flame. It's weird as we both have different initial state. Maybe the safest option would be to just use image instead. 

What do you think?

Fang, could you please help us with 1/1.5/2/2.25 image assets for the "+" (add contact) button so that it looks the same on all devices?

Thanks!
Flags: needinfo?(fshih)

Comment 8

4 years ago
Created attachment 8487827 [details]
plus_assets.zip

Hi Oleg,
Here are the image assets for the "+", Thanks! :)
Flags: needinfo?(fshih)
About the "+" issue, can you all check you have the correct fonts?

Updated

4 years ago
Blocks: 1069288
(Assignee)

Comment 10

4 years ago
Comment on attachment 8479089 [details] [review]
pull-request (master)

Update the patch to use official gaia-icons 'add' icon.
Attachment #8479089 - Flags: review?(azasypkin)
(Assignee)

Comment 11

4 years ago
Created attachment 8518195 [details] [review]
pull-request (master)
Attachment #8479089 - Attachment is obsolete: true
Attachment #8479089 - Flags: review?(azasypkin)
Attachment #8518195 - Flags: review?(azasypkin)
Comment on attachment 8518195 [details] [review]
pull-request (master)

Looks good to me, thanks Wilson!

But since size of "+" has changed a bit, let's reconfirm with Fang and we're good to go.
Attachment #8518195 - Flags: review?(azasypkin) → review+
Created attachment 8519968 [details]
add_contact_plus_icon.png

Hey Fang,

Size of "+" ("add contact" button next to the recipients input) is going to change a bit in this patch. Could you please confirm that it's still ok for you?

Thanks!
Attachment #8519968 - Flags: ui-review?(fshih)

Comment 14

4 years ago
Hey Oleg, 

Is there any reason we make them in different size in this patch? The only thing I concern here is we also want to make sure the + button is in the same size with Email's "+". Is there any way we can know we are using the same size here? Or anything I can provide, please let me know. Thanks!
Flags: needinfo?(azasypkin)
Redirecting question to Wilson :)
Flags: needinfo?(azasypkin) → needinfo?(wilsonpage)
Note that Wilson is in PTO :)
(In reply to Julien Wajsberg [:julienw] from comment #16)
> Note that Wilson is in PTO :)

Thanks for the note! I guess we can wait as it isn't that critical :)
(Assignee)

Comment 18

4 years ago
Apologies, I will make sure size is exactly same as before patch, and then land.
Flags: needinfo?(wilsonpage)
(Assignee)

Comment 19

4 years ago
For some reason, I'm not seeing the misalignment anymore on master! I'm going to close this. Will re-open if it returns.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
Comment on attachment 8519968 [details]
add_contact_plus_icon.png

Okay, removing ui-review request then
Attachment #8519968 - Flags: ui-review?(fshih)
You need to log in before you can comment on or make changes to this bug.