1058640 - IonMonkey MIPS: Adapt testJitMoveEmitterCycles.cpp to work on MIPS.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Branislav Rankov [:rankov]]

Test testJitMoveEmitterCycles.cpp currently only works on ARM simulator. We need to run these tests on MIPS simulator too.

Comment 1

[Branislav Rankov [:rankov]]

Attachment: Fix-testJitMoveEmitterCycles-mips.patch

I created a separate file for MIPS. I could merge it into the same file with ARM, but there would be a lot of #ifdef. 
The main problem is that I have to remove lines that use regs f18 and f19 because MIPS uses them as scratch in Move Emitter.

Comment 2

[Branislav Rankov [:rankov]]

Attachment: Fix-testJitMoveEmitterCycles-mips.patch

Fixed error in make check.

Comment 3

[Marty Rosenberg [:mjrosenb]]

Comment on attachment 8482831 [details] [diff] [review]
Fix-testJitMoveEmitterCycles-mips.patch

Review of attachment 8482831 [details] [diff] [review]:
-----------------------------------------------------------------

Is that test file justa translation of the arm version?  If so, we may want to find a way to merge them.

Comment 4

[Branislav Rankov [:rankov]]

It is a translation from ARM. I created a separate file to avoid ifdefs regarding use of f18 and f19 registers. These are used as Scratch on MIPS.

Comment 5

[Branislav Rankov [:rankov]]

Attachment: Fix-testJitMoveEmitterCycles-mips.patch

Rebased the patch so that it can be applied.
Carry review from previous patch.

Comment 6

[Branislav Rankov [:rankov]]

I will submit it as is for now and create a new bug to add spillSlot to MIPS MoveEmitter, so that it is more similar to ARM implementation, and that same tests can be used.

Comment 7

[Branislav Rankov [:rankov]]

https://tbpl.mozilla.org/?tree=Try&rev=1e102a32ee69

Comment 8

[Branislav Rankov [:rankov]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c64a01056ea1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c64a01056ea1