Closed Bug 1058671 Opened 10 years ago Closed 10 years ago

Cache GeoIP results.

Categories

(support.mozilla.org :: General, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
2014Q3

People

(Reporter: mythmon, Assigned: mythmon)

References

Details

(Whiteboard: u=user c=general p=1 s=2014.16)

Right now every page in every locale for every user will make a GeoIP request. We don't need to do this if the user a) is in a country we don't care about, or b) if the user has declined the automatic language switch. This will avoid making extraneous network requests.

One way to do this is to use a cookie that the JS sets when the user declines, and check that cookie at render time.

Estimating this at 1pt.
Priority: -- → P2
Target Milestone: --- → 2014Q3
Assignee: nobody → mcooper
Editing description. This bug is actually going to be a slightly more general approach that just caches the GeoIP data instead of getting it every time. This will be a better overall approach to solving the same problem.
Summary: Don't make GeoIP requests for users that decliend or won't need to switch locales. → Cache GeoIP results.
Landed in https://github.com/mozilla/kitsune/commit/35f80a765fe97f87703e95296d36afd3b636754f

I deployed this to prod.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.