User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release) Build ID: 20140716183446 Steps to reproduce: Go to https://support.mozilla.org/en-US/users/settings and select all the options i guess. Actual results: When other localizers make an review i recieve an e-mails about it with a link to the review, but when i visit the link i get this page: ' Access denied You do not have permission to access this page. ' Expected results: If i dont have permission to view the review i guess there is not need for me to recieve e-mails about it.
I'm still receiving these e-mails about reviews other peoples are making in my local group with links in them that i dont have permission to read. Here are some of the links : https://support.mozilla.org/da/kb/filelink-til-store-vedhaeftede-filer/review/81045?utm_campaign=wiki-ready-review&utm_medium=email&utm_source=notification https://support.mozilla.org/da/kb/firefox-fryser-eller-svarer-ikke-saadan-loeses-det/review/81054?utm_campaign=wiki-ready-review&utm_medium=email&utm_source=notification https://support.mozilla.org/da/kb/installation-af-firefox-i-windows/review/81050?utm_campaign=wiki-ready-review&utm_medium=email&utm_source=notification https://support.mozilla.org/da/kb/nulstil-indstillinger-i-firefox-fejlsoge-og-rette-/review/81098?utm_campaign=wiki-ready-review&utm_medium=email&utm_source=notification
Hi scootergrisen, What message do you get on the target page when you click the link? Can you paste it here? Thanks!
' Access denied You do not have permission to access this page. '
Weird.. I wonder what permission you are missing.
This may be caused by scootergrisen not having Reviewer permissions. Can we strip the outgoing emails from review links for users who don't have such permissions?
True i dont have reviwer permission at the moment : https://support.mozilla.org/da/kb/locales/da
Somebody from SUMODEV would need to comment. Maybe rdalal?
Summary: Reciving E-mails with links that i does have access to read → Remove review links from emails outgoing to users who don't have reviewer permissions
Michal, should we even send these emails to people who are not reviewers?
Kadir: Ideally, the Reviewers would get one email (along the lines of "Article X is ready for your review"), and the submitters would get another (along the lines of "Your contribution is undergoing review. Thank you!") If it's easier to switch notification emails off for non-reviewers, let's go for that, and explore the "ideal" scenario later.
Mike, can you give us an estimate for both cases?
Whiteboard: p=? u=contributors
Looking through the code that sends these notifications, I think it would be 1 point to remove the notification for people without the review permission, and another point to add the second email.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Thanks, Mike. Let's go for the first option, then? The latter (since it's possible) can wait a bit.
Ok. I've updated this bug to reflect that. Vesper, can you file another bug for the new email, so we can track it separately?
Summary: Remove review links from emails outgoing to users who don't have reviewer permissions → Don't send review emails to users without review permission
Whiteboard: p=? u=contributors → p=1 u=contributors
Filed and prioritized in the backlog as https://bugzilla.mozilla.org/show_bug.cgi?id=1215087
Assignee: nobody → rdalal
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.