Closed Bug 1058781 Opened 10 years ago Closed 10 years ago

[RTL] The app permission list is not RTL

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:+, b2g-v2.1 affected)

Status:
VERIFIED FIXED
Milestone:
2.2 S1 (5dec)
Project Flags:
tracking-b2g +
Tracking Flags:
Tracking Status
b2g-v2.1 --- affected

People

(Reporter: jlorenzo, Assigned: arthurcc)

References

Details

(Whiteboard: [2.1-Arabic-RTL-bug-bash][p=1])

Attachments

(2 files)

link to https://github.com/mozilla-b2g/gaia/pull/26321
182 bytes, text/html
eragonj
: review+
Details
rtl.png
48.84 KB, image/png
HHuang
: ui-review+
Details 
Build Information
Gaia      4d1d0ea5a82cddeeab497774cfa1703639e3c7d9
Gecko     https://hg.mozilla.org/mozilla-central/rev/dc352a7bf234
BuildID   20140826040204
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Steps to Reproduce:
1. Go to settings, App permissions

Expected Results:
The list is RTL, like any other list.

Actual Results:
The list is still LTR.

Reproduction Frequency: 100%
Blocks: settings-rtl
No longer blocks: gaia-rtl
feature-b2g: --- → 2.2+
blocking-b2g: --- → backlog
Assignee: nobody → arthur.chen
Status: NEW → ASSIGNED
Whiteboard: [2.1-Arabic-RTL-bug-bash] → [2.1-Arabic-RTL-bug-bash][p=1]
Target Milestone: --- → 2.2 S1 (5dec)
EJ, could you help review the patch? Thanks.
Attachment #8525893 - Flags: review?(ejchen)
Comment on attachment 8525893 [details]
link to https://github.com/mozilla-b2g/gaia/pull/26321

Looks nice to me ! Please set remember set ui-r? on Helen to check again about the layout :)
Attachment #8525893 - Flags: review?(ejchen) → review+
Attached image rtl.png — 
Helen, could you help review the RTL layout? Thanks.
Attachment #8526598 - Flags: review?(hhuang)
Attachment #8526598 - Flags: review?(hhuang) → ui-review?(hhuang)
Comment on attachment 8526598 [details]
rtl.png

It's good, thanks!
Attachment #8526598 - Flags: ui-review?(hhuang) → ui-review+
Thanks EJ and Helen!

master: a7aaa0a8e5a7271918fd35edf37092474487fb4c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Remove the feature b2g tag to match the new v2.2 scope.
feature-b2g: 2.2+ → ---
Verified the fix, closing bug
Status: RESOLVED → VERIFIED
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15750/
Flags: in-moztrap+
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: