Closed
Bug 1058797
Opened 10 years ago
Closed 10 years ago
Intermittent test_303567.xul | Result logged after SimpleTest.finish()
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 35
Tracking | Status | |
---|---|---|
firefox33 | --- | fixed |
firefox34 | --- | fixed |
firefox35 | --- | fixed |
firefox-esr31 | --- | unaffected |
People
(Reporter: RyanVM, Assigned: martijn.martijn)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
1.62 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=46757989&tree=Mozilla-Inbound Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-other on 2014-08-26 02:46:59 PDT for push 75805f95cfbe slave: t-snow-r4-0026 02:55:14 INFO - 4132 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul 02:55:15 INFO - 4133 INFO TEST-OK | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul | took 187ms 02:55:15 INFO - 4134 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul | Loading livemark should success - Result logged after SimpleTest.finish() 02:55:15 INFO - 4135 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul | Ensure all the livemark items were created. - Result logged after SimpleTest.finish() 02:55:15 INFO - 4136 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul | Ensure link-less livemark item picked up site uri. - Result logged after SimpleTest.finish() 02:55:15 INFO - 4137 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul | Ensure link-less livemark item picked up site uri. - Result logged after SimpleTest.finish() 02:55:15 INFO - 4138 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/places/tests/chrome/test_303567.xul | Ensure link-less livemark item picked up site uri. - Result logged after SimpleTest.finish()
Reporter | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=46783017&tree=Mozilla-Inbound
Assignee | ||
Comment 2•10 years ago
|
||
Something like this should fix it, but I don't know if it's the right solution.
Attachment #8479248 -
Flags: review?(mak77)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•10 years ago
|
Attachment #8479248 -
Flags: review?(mano)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 8•10 years ago
|
||
Comment on attachment 8479248 [details] [diff] [review] 1058797.diff Review of attachment 8479248 [details] [diff] [review]: ----------------------------------------------------------------- yes the problem looks related to unsorted loading of the feeds. I don't like much the counters approach though, ideally I'd prefer a promises (with Promise.All) approach, but here I think you might just do something like: waitForLivemarkLoad(aLivemark, function (aLivemark) { aLivemarkData.loaded = true; ... ... PlacesUtils.bookmarks.removeItem(aLivemark.id); if (LIVEMARKS.every(lm => lm.loaded)) Simpletest.finish(); ... so basically flag each livemark object in the array with a .loaded property.
Attachment #8479248 -
Flags: review?(mano)
Attachment #8479248 -
Flags: review?(mak77)
Attachment #8479248 -
Flags: feedback+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → martijn.martijn
Assignee | ||
Comment 9•10 years ago
|
||
Thanks, that seems to work.
Attachment #8479248 -
Attachment is obsolete: true
Attachment #8484181 -
Flags: review?(mak77)
Comment 10•10 years ago
|
||
Comment on attachment 8484181 [details] [diff] [review] 1058797.diff (for check-in) Review of attachment 8484181 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8484181 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=4ceaf9998075
Assignee | ||
Comment 12•10 years ago
|
||
The failures are there, because I made an error in the patch for bug 1062367. I pushed another one to try: https://tbpl.mozilla.org/?tree=Try&rev=443c08f476fc This one looks completely green, this patch is ready to be checked in.
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Attachment #8484181 -
Attachment description: 1058797.diff → 1058797.diff (for check-in)
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/db7bb614c999
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/db7bb614c999
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Reporter | ||
Comment 15•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3d0e91a983a8 https://hg.mozilla.org/releases/mozilla-beta/rev/d2d97af8ecdd
status-firefox33:
--- → fixed
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
status-firefox-esr31:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•