Closed Bug 1058829 Opened 5 years ago Closed 5 years ago

Allow users to try window/screen sharing on XP and Mac 10.6 via about:config pref

Categories

(Core :: WebRTC: Audio/Video, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file, 1 obsolete file)

Window and screen sharing (especially screen sharing) has issues on WinXP and OSX 10.6, and they've been blocked by default.  Provide a pref that enables them anyways for testing and caveat emptor use.
Attachment #8479253 - Flags: review?(jib)
Comment on attachment 8479253 [details] [diff] [review]
enable users to enable window/screensharing on WinXP and 10.6 via pref

Review of attachment 8479253 [details] [diff] [review]:
-----------------------------------------------------------------

r- test of pref needs to be inverted.

::: dom/media/MediaManager.cpp
@@ +1606,5 @@
>        // Block screen/window sharing on Mac OSX 10.6 and WinXP until proved that they work
>        if (
> +#if defined(XP_MACOSX) || defined(XP_WIN)
> +          (
> +            Preferences::GetBool("media.getusermedia.screensharing.allow_on_old_platforms", false) &&

!Preferences::GetBool("media.getusermedia.screensharing.allow_on_old_platforms", false) &&
Attachment #8479253 - Flags: review?(jib) → review-
Attachment #8479253 - Attachment is obsolete: true
Attachment #8479275 - Flags: review?(jib)
Comment on attachment 8479275 [details] [diff] [review]
enable users to enable window/screensharing on WinXP and 10.6 via pref

Review of attachment 8479275 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, though there's a lot of nots here. Have we considered inverting the if-statement?

>        if (!(
> #if defined(XP_MACOSX) || defined(XP_WIN)
>           (
> #if defined(XP_MACOSX)
>             nsCocoaFeatures::OnLionOrLater()
> #endif
> #if defined (XP_WIN)
>             IsVistaOrLater()
> #endif
>            || Preferences::GetBool("media.getusermedia.screensharing.allow_on_old_platforms",
>                                    false)) &&
> #endif
>            (aPrivileged || HostHasPermission(*docURI)))) {
>         return runnable->Denied(NS_LITERAL_STRING("PERMISSION_DENIED"));
>       }
Attachment #8479275 - Flags: review?(jib) → review+
https://hg.mozilla.org/mozilla-central/rev/2accec91fd6e
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1329562
You need to log in before you can comment on or make changes to this bug.