Closed Bug 1058845 Opened 5 years ago Closed 5 years ago

mach mercurial-setup does not support non-ascii usernames characters

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: tomasz, Assigned: u520979)

Details

Attachments

(1 file)

Repro 

1. Change your username to Koło <something@example.com>
2. run mach-mercurial
3. crash: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 13: ordinal not in range(128)

It also happens if I just run it without any configuration (first time run) and I type my last name into the terminal.
This is my first contribution to Mozilla, could you assign me to the bug while reviewing the patch please.
Attachment #8511311 - Flags: review?(gps)
I'll try to look at this soon. Currently trying to unbreak something.
Assignee: nobody → dev
Status: NEW → ASSIGNED
Comment on attachment 8511311 [details] [diff] [review]
bug1058845_python-utf8.diff

Review of attachment 8511311 [details] [diff] [review]:
-----------------------------------------------------------------

This technically probably isn't perfect - we should probably respect ENCODING or some such. But this is better than ASCII, so r+.
Attachment #8511311 - Flags: review?(gps) → review+
Congratulations on your first patch!
https://hg.mozilla.org/mozilla-central/rev/8add8629f765
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.