Disable AlarmsManager in prerendering

RESOLVED FIXED in mozilla37

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rvid, Assigned: rvid)

Tracking

(Blocks: 1 bug)

unspecified
mozilla37
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 730101
(Assignee)

Comment 1

4 years ago
Created attachment 8483774 [details] [diff] [review]
1058904.patch
Assignee: nobody → roshanvid
(Assignee)

Updated

4 years ago
Attachment #8483774 - Flags: review?(jst)
Comment on attachment 8483774 [details] [diff] [review]
1058904.patch

 interface AlarmsManager {
   DOMRequest getAll();
+  [UnsafeInPrerendering]
   DOMRequest add(any date, DOMString respectTimezone, optional any data);
+  [UnsafeInPrerendering]
   void remove(unsigned long id);

Technically we shouldn't need to worry about remove() here as in there's never going to be anything to remove since we don't permit adds. r=jst with that.
Attachment #8483774 - Flags: review?(jst) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8507450 [details] [diff] [review]
1058904.patch
Attachment #8483774 - Attachment is obsolete: true
Attachment #8507450 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Hi Roshan,

Checkin needed bugs require a successful try run.

Could you provide a try results (just to make sure nothing breaks etc) maybe https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices can helpful.

Thanks!
Keywords: checkin-needed
FWIW there might be things to remove, since the page might have been added alarms before.
https://hg.mozilla.org/mozilla-central/rev/96271c3f7dae
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.