Closed Bug 1058904 Opened 7 years ago Closed 6 years ago

Disable AlarmsManager in prerendering

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: rvid, Assigned: rvid)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: prerendering
Attached patch 1058904.patch (obsolete) — Splinter Review
Assignee: nobody → roshanvid
Attachment #8483774 - Flags: review?(jst)
Comment on attachment 8483774 [details] [diff] [review]
1058904.patch

 interface AlarmsManager {
   DOMRequest getAll();
+  [UnsafeInPrerendering]
   DOMRequest add(any date, DOMString respectTimezone, optional any data);
+  [UnsafeInPrerendering]
   void remove(unsigned long id);

Technically we shouldn't need to worry about remove() here as in there's never going to be anything to remove since we don't permit adds. r=jst with that.
Attachment #8483774 - Flags: review?(jst) → review+
Attached patch 1058904.patchSplinter Review
Attachment #8483774 - Attachment is obsolete: true
Attachment #8507450 - Flags: review+
Keywords: checkin-needed
Hi Roshan,

Checkin needed bugs require a successful try run.

Could you provide a try results (just to make sure nothing breaks etc) maybe https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices can helpful.

Thanks!
Keywords: checkin-needed
FWIW there might be things to remove, since the page might have been added alarms before.
https://hg.mozilla.org/mozilla-central/rev/96271c3f7dae
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.