1058904 - Disable AlarmsManager in prerendering

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Roshan Vidyashankar [:rvid]]

Attachment: 1058904.patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 8483774 [details] [diff] [review]
1058904.patch

 interface AlarmsManager {
   DOMRequest getAll();
+  [UnsafeInPrerendering]
   DOMRequest add(any date, DOMString respectTimezone, optional any data);
+  [UnsafeInPrerendering]
   void remove(unsigned long id);

Technically we shouldn't need to worry about remove() here as in there's never going to be anything to remove since we don't permit adds. r=jst with that.

Comment 3

[Roshan Vidyashankar [:rvid]]

Attachment: 1058904.patch

Comment 4

[Carsten Book [:Tomcat]]

Hi Roshan,

Checkin needed bugs require a successful try run.

Could you provide a try results (just to make sure nothing breaks etc) maybe https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices can helpful.

Thanks!

Comment 5

[(no longer active)]

FWIW there might be things to remove, since the page might have been added alarms before.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96271c3f7dae