Closed Bug 1058913 Opened 7 years ago Closed 7 years ago

Disable DOMDownloadManager in prerendering

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: rvid, Assigned: rvid)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: prerendering
Attached patch 1058913.patch (obsolete) — Splinter Review
Assignee: nobody → roshanvid
Attachment #8483782 - Flags: review?(jst)
Comment on attachment 8483782 [details] [diff] [review]
1058913.patch

r=jst for these changes, but we should also ensure that no downloads can be started while prerendering.
Attachment #8483782 - Flags: review?(jst) → review+
Attached patch 1058918.patchSplinter Review
Attachment #8483782 - Attachment is obsolete: true
Attachment #8507452 - Flags: review+
Keywords: checkin-needed
Hi Roshan,

Checkin needed bugs require a successful try run.

Could you provide a try results (just to make sure nothing breaks etc) maybe https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices can helpful.

Thanks!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a320ddd80444
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.