Closed
Bug 1058954
Opened 7 years ago
Closed 7 years ago
"ASSERTION: writing-mode mismatch" with -moz-grid-line, rtl, R&A pos
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jruderman, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
(Keywords: assertion, testcase)
Attachments
(4 files, 1 obsolete file)
240 bytes,
text/html
|
Details | |
12.26 KB,
text/plain
|
Details | |
2.62 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
1.23 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == mWritingMode', file WritingModes.h, line 638
Reporter | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Looks like the assertion will happen if the outer <div> in this testcase has any of the XUL 'display' types, such as '-moz-deck' or '-moz-box' or '-moz-inline-box', etc.
Assignee | ||
Comment 3•7 years ago
|
||
I think this is a simple fix, as attached. Pushed to tryserver to check it doesn't break existing tests; if all goes well, I will flag for review. Try job: https://tbpl.mozilla.org/?tree=Try&rev=18370a2dfc46.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•7 years ago
|
||
Tryserver seems happy with this. Also simplified a couple usages of GetLogicalSize while we're here.
Attachment #8479864 -
Flags: review?(smontagu)
Assignee | ||
Updated•7 years ago
|
Attachment #8479783 -
Attachment is obsolete: true
Assignee | ||
Comment 5•7 years ago
|
||
Just adding Jesse's testcase as a crashtest.
Attachment #8479865 -
Flags: review?(smontagu)
Comment 6•7 years ago
|
||
Comment on attachment 8479864 [details] [diff] [review] use logical-size with the proper writing mode when setting up to call ReflowAbsoluteFrames. Review of attachment 8479864 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsFrame.cpp @@ +8195,5 @@ > // Set up a |reflowState| to pass into ReflowAbsoluteFrames > nsHTMLReflowState reflowState(aState.PresContext(), this, > aState.GetRenderingContext(), > + LogicalSize(ourWM, > + GetLogicalSize().ISize(ourWM), I think you can simplify this further to |ISize()|
Attachment #8479864 -
Flags: review?(smontagu) → review+
Updated•7 years ago
|
Attachment #8479865 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Simon Montagu :smontagu from comment #6) > I think you can simplify this further to |ISize()| Duh, of course. Done. https://hg.mozilla.org/integration/mozilla-inbound/rev/9dfc18e7a392 https://hg.mozilla.org/integration/mozilla-inbound/rev/a07f6bc9c1d9
Target Milestone: --- → mozilla34
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9dfc18e7a392 https://hg.mozilla.org/mozilla-central/rev/a07f6bc9c1d9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 9•6 years ago
|
||
This bug's crashtest was added out of order, in the second cset in comment 7. I just pushed a fix to reorder this & restore numerical order: https://hg.mozilla.org/integration/mozilla-inbound/rev/00781c452427
You need to log in
before you can comment on or make changes to this bug.
Description
•