1058954 - "ASSERTION: writing-mode mismatch" with -moz-grid-line, rtl, R&A pos

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == mWritingMode', file WritingModes.h, line 638

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jonathan Kew (:jfkthame)]

Looks like the assertion will happen if the outer <div> in this testcase has any of the XUL 'display' types, such as '-moz-deck' or '-moz-box' or '-moz-inline-box', etc.

Comment 3

[Jonathan Kew (:jfkthame)]

Attachment: use logical-size with the proper writing mode when setting up to call ReflowAbsoluteFrames.

I think this is a simple fix, as attached. Pushed to tryserver to check it doesn't break existing tests; if all goes well, I will flag for review. Try job: https://tbpl.mozilla.org/?tree=Try&rev=18370a2dfc46.

Comment 4

[Jonathan Kew (:jfkthame)]

Attachment: use logical-size with the proper writing mode when setting up to call ReflowAbsoluteFrames.

Tryserver seems happy with this. Also simplified a couple usages of GetLogicalSize while we're here.

Comment 5

[Jonathan Kew (:jfkthame)]

Attachment: add testcase.

Just adding Jesse's testcase as a crashtest.

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 8479864 [details] [diff] [review]
use logical-size with the proper writing mode when setting up to call ReflowAbsoluteFrames.

Review of attachment 8479864 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFrame.cpp
@@ +8195,5 @@
>      // Set up a |reflowState| to pass into ReflowAbsoluteFrames
>      nsHTMLReflowState reflowState(aState.PresContext(), this,
>                                    aState.GetRenderingContext(),
> +                                  LogicalSize(ourWM,
> +                                              GetLogicalSize().ISize(ourWM),

I think you can simplify this further to |ISize()|

Comment 7

[Jonathan Kew (:jfkthame)]

(In reply to Simon Montagu :smontagu from comment #6)
> I think you can simplify this further to |ISize()|

Duh, of course. Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dfc18e7a392
https://hg.mozilla.org/integration/mozilla-inbound/rev/a07f6bc9c1d9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9dfc18e7a392
https://hg.mozilla.org/mozilla-central/rev/a07f6bc9c1d9

Comment 9

[Daniel Holbert [:dholbert]]

This bug's crashtest was added out of order, in the second cset in comment 7.

I just pushed a fix to reorder this & restore numerical order:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/00781c452427

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00781c452427