Closed Bug 1058954 Opened 5 years ago Closed 5 years ago

"ASSERTION: writing-mode mismatch" with -moz-grid-line, rtl, R&A pos

Categories

(Core :: Layout, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jruderman, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(4 files, 1 obsolete file)

Attached file testcase
###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == mWritingMode', file WritingModes.h, line 638
Attached file stack
Looks like the assertion will happen if the outer <div> in this testcase has any of the XUL 'display' types, such as '-moz-deck' or '-moz-box' or '-moz-inline-box', etc.
I think this is a simple fix, as attached. Pushed to tryserver to check it doesn't break existing tests; if all goes well, I will flag for review. Try job: https://tbpl.mozilla.org/?tree=Try&rev=18370a2dfc46.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Tryserver seems happy with this. Also simplified a couple usages of GetLogicalSize while we're here.
Attachment #8479864 - Flags: review?(smontagu)
Attachment #8479783 - Attachment is obsolete: true
Attached patch add testcase.Splinter Review
Just adding Jesse's testcase as a crashtest.
Attachment #8479865 - Flags: review?(smontagu)
Comment on attachment 8479864 [details] [diff] [review]
use logical-size with the proper writing mode when setting up to call ReflowAbsoluteFrames.

Review of attachment 8479864 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFrame.cpp
@@ +8195,5 @@
>      // Set up a |reflowState| to pass into ReflowAbsoluteFrames
>      nsHTMLReflowState reflowState(aState.PresContext(), this,
>                                    aState.GetRenderingContext(),
> +                                  LogicalSize(ourWM,
> +                                              GetLogicalSize().ISize(ourWM),

I think you can simplify this further to |ISize()|
Attachment #8479864 - Flags: review?(smontagu) → review+
Attachment #8479865 - Flags: review?(smontagu) → review+
(In reply to Simon Montagu :smontagu from comment #6)
> I think you can simplify this further to |ISize()|

Duh, of course. Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dfc18e7a392
https://hg.mozilla.org/integration/mozilla-inbound/rev/a07f6bc9c1d9
Target Milestone: --- → mozilla34
https://hg.mozilla.org/mozilla-central/rev/9dfc18e7a392
https://hg.mozilla.org/mozilla-central/rev/a07f6bc9c1d9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
This bug's crashtest was added out of order, in the second cset in comment 7.

I just pushed a fix to reorder this & restore numerical order:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/00781c452427
You need to log in before you can comment on or make changes to this bug.