Closed Bug 1058977 Opened 6 years ago Closed 6 years ago

[e10s] Fix mochitests that create/delete temporary files in content processes

Categories

(Core :: Security, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
e10s + ---

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(1 file, 1 obsolete file)

There are a few mochitests that create/delete temporary files via SpecialPowers while running in a content process.  This needs to move to the parent process (either the entire test or just that part of the script, as appropriate), or if it's not actually necessary for the test it can just be removed.

This is, as the bug dependencies suggest, a blocker for some important sandboxing milestones (at least on Linux/B2G, but this may be helpful for the other platforms).
This is mostly changes to forms tests using the file upload widget.  There's also one of nsWebBrowserPersist (the one under embedding/), whose exact fate is still undecided (bug 1058251), but since "File > Save Page As..." doesn't exist on B2G, making it mochitest-chrome at least isn't losing meaningful test coverage (if I understand correctly).
Attachment #8481014 - Flags: review?(bzbarsky)
Comment on attachment 8481014 [details] [diff] [review]
bug1058977-mochi-content-tempfile-hg0.diff

>+++ b/content/base/test/test_bug345339.html
>+++ b/content/html/content/test/forms/test_max_attribute.html
>+++ b/content/html/content/test/forms/test_min_attribute.html
>+++ b/content/html/content/test/forms/test_required_attribute.html
>+++ b/content/html/content/test/forms/test_step_attribute.html

Maybe add comments about how we never touch the actual data in the file so it doesn't actually need to exist?

>+++ b/content/html/content/test/forms/test_submit_invalid_file.html
>+  <form action='http://test/chrome/content/html/content/test/forms>/submit_invalid_file.sjs' method='post' target='result'

I'd rather you use mochi.test:8888 as the hostport, like other tests do.  The fact that "test" works is pretty non-obvious.

r=me
Attachment #8481014 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] from comment #2)
> Maybe add comments about how we never touch the actual data in the file so
> it doesn't actually need to exist?

Sure.

> >+++ b/content/html/content/test/forms/test_submit_invalid_file.html
> >+  <form action='http://test/chrome/content/html/content/test/forms>/submit_invalid_file.sjs' method='post' target='result'
> 
> I'd rather you use mochi.test:8888 as the hostport, like other tests do. 
> The fact that "test" works is pretty non-obvious.

I copied it from an existing test, which may or may not have had a reason to do that.  Fixed; thanks.

(I'll update the attachment after it passes Try.)
https://tbpl.mozilla.org/?tree=Try&rev=e2f4cf893d1f (tested with other, not-yet-ready, patches to try to make sure that this is still all of the tests that need changes).

Carrying over r+.
Attachment #8481014 - Attachment is obsolete: true
Attachment #8486154 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2743fe09d35a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.