Closed
Bug 1059026
Opened 10 years ago
Closed 8 years ago
Consider replacing imgFrame::mOffset and imgFrame::mSize with a single rect member variable
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: seth, Unassigned)
References
Details
Attachments
(1 file)
|
15.99 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
It seems cleaner to just store a single rect in imgFrame instead of both mOffset and mSize.
|
Reporter | |
Comment 1•8 years ago
|
||
This change is long overdue.
Attachment #8756615 -
Flags: review?(edwin)
Attachment #8756615 -
Flags: review?(edwin) → review+
|
|
Reporter | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=446a01d33317
|
|
Reporter | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d452f7cdc61e607a53c996798a14d93ab9d30378 Bug 1059026 - Replace imgFrame::mOffset and imgFrame::mSize with imgFrame::mFrameRect. r=edwin
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d452f7cdc61e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•