1059029 - Fix some tiled draw target bugs

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: tile-buffering-fixes

Just a few issues that cause us to fail reftests with tiling enabled.

We sometime end up with a backbuffer even when HasInternalBuffer is true because we're producing content faster than we can upload. Not discarding the back buffer helps for that, and we have TileExpiry to make sure it goes away 'soon'

Comment 1

[Nicolas Silva [:nical]]

Comment on attachment 8479518 [details] [diff] [review]
tile-buffering-fixes

Review of attachment 8479518 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +1167,5 @@
>                              NS_roundf((dirtyRect->y - mSinglePaintBufferOffset.y) * mResolution),
>                              drawRect.width,
>                              drawRect.height);
>        gfx::IntPoint copyTarget(NS_roundf(drawRect.x), NS_roundf(drawRect.y));
>        // Mark the newly updated area as invalid in the front buffer

please update this comment too (front -> back)

Comment 2

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd00d686183f

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fd00d686183f