Convert Keyboard-Symbols.woff to Keyboard-Symbols.ttf

RESOLVED FIXED in 2.1 S3 (29aug)

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mnjul, Assigned: mnjul)

Tracking

unspecified
2.1 S3 (29aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1056514 +++

(In reply to Michael Wu [:mwu] from comment #4)
> That bug was backed out - RESOLVED WONTFIX. A new font fastpath landed in
> bug 1036394 which requires referencing a separate font rather than embedding
> a font. TTF is also preferred over OTF with this approach.

According to bug 1056514 comment 4, we should use TTF format for the Keyboard-Symbols.woff . This bug will deal with it.
See Also: → bug 1056514
Created attachment 8479573 [details] [review]
Patch (PR @ GitHub)

Hi Yuren and Michael,

Please kindly check if the patch looks good for you. The TTF file was generated from this SVG https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/style/fonts/Keyboard-Symbols by this script: https://github.com/fontello/svg2ttf .

Thanks a lot!
Attachment #8479573 - Flags: review?(yurenju.mozilla)
Attachment #8479573 - Flags: feedback?(mwu)
Assignee: nobody → jlu
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S3 (29aug)
Attachment #8479573 - Flags: review?(yurenju.mozilla) → review+

Comment 2

3 years ago
Comment on attachment 8479573 [details] [review]
Patch (PR @ GitHub)

No idea - you'd have to ask jfkthame if you want to know if your font looks ok.
Attachment #8479573 - Flags: feedback?(mwu)
Well, the font only has four characters (glyphs I mean) and all used by keyboards. With my raw eyes they look identical. I think I'll land it.
Master: https://github.com/mozilla-b2g/gaia/commit/50ecd2b44e14df50b1c022affea796e06dae8370

(one Gij failure in TBPL but other PRs are failing it too and is unlikely this patch's fault).
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Just making a note that we were sheriffing some build failures and reverted this, but it appears to be the wrong bug. It is now landed, but just replying here with these commits in case there are any follow-ups.

backed out: 7f44b868861c6ad33dc8b081c148365f6390a3eb
backout reverted: f8dc5b863e5f00befb45e63452a45fa1aa5bf2ed

(This bug remains landed and you are all good here)
You need to log in before you can comment on or make changes to this bug.