Closed Bug 1059052 Opened 5 years ago Closed 5 years ago

Improve MediaDecoderStateMachine state transition - centralize state transitions

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

Spin off of bug 1054831 comment 1 and bug 1054831 comment 2.

Centralizing state transitions will allow us to track state changes more easily and it is also a prerequisite for adding entry/exit actions to state transition to enhance our state machine.
Move all |mState = XXX| to SetState() and add logs to track state transition.

Try: https://tbpl.mozilla.org/?tree=Try&rev=67a69ceb7138
The status of B2G ICS Emulator Opt is bad. Most of them are bug 1059120. So I guess my patch is fine then.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8480460 - Flags: review?(cpearce)
Attachment #8480460 - Flags: review?(cpearce) → review+
See comment 1 for the Try results.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9ef1298abf22
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.