non-ion builds fail with AsmJSGlobalRegBias’ was not declared in this scope

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: stevensn, Assigned: dougc)

Tracking

Trunk
mozilla34
Other
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Non-ion builds (ppc64) are failing with the following error

/home/buildbot/buildbot/slave/runtests/build/js/src/asmjs/AsmJSValidate.cpp:6259:72: error: ‘AsmJSGlobalRegBias’ was not declared in this scope
 8:28.69      masm.computeEffectiveAddress(Address(GlobalReg, globalDataOffset - AsmJSGlobalRegBias), callee);
 8:28.69 



static const int32_t AsmJSGlobalRegBias 
needs to be added to the none asmjs backend
Sorry about that, does this fix it?
Attachment #8479591 - Flags: feedback?(steve)
Comment on attachment 8479591 [details] [diff] [review]
Avoid referencing AsmJSGlobalRegBias except for the ARM and MIPS backends.

Yes this fixes the issue.
Thanks
Attachment #8479591 - Flags: feedback?(steve) → feedback+
Comment on attachment 8479591 [details] [diff] [review]
Avoid referencing AsmJSGlobalRegBias except for the ARM and MIPS backends.

Sorry forgot about this one.
Attachment #8479591 - Flags: review?(luke)
Attachment #8479591 - Flags: review?(luke) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e3092e36afb0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.