Closed Bug 1059079 Opened 5 years ago Closed 5 years ago

Increase wait_for_homescreen timeout and patch URL check

Categories

(Testing :: Mozbase, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: qdot, Assigned: qdot)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

We're getting anywhere from 50-100 second startups of the emulator in Mnw tests, and with Bug 900551 doing a lot of IPC on startup now, this has increased even more, sometimes causing the homescreen wait to timeout.

Also, in the wait for homescreen function, we only look for "ftu" or "homescreen". However, as of FxOS 2.0 homescreen is now "verticalhome", so we should look for that when triggering. There are better ways to do this (via checking settings in the system), but they're rather complicated so I'll file a followup for that.
Adding multiple reviewers because I can't land Bug 900551 without this. Whoever gets to it first wins!
Attachment #8479599 - Flags: review?(mdas)
Attachment #8479599 - Flags: review?(ahalberstadt)
Comment on attachment 8479599 [details] [diff] [review]
Patch 1 (v1) - Increase wait_for_homescreen timeout and add watch for new homescreen name

Review of attachment 8479599 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks
Attachment #8479599 - Flags: review?(mdas) → review+
Comment on attachment 8479599 [details] [diff] [review]
Patch 1 (v1) - Increase wait_for_homescreen timeout and add watch for new homescreen name

Review of attachment 8479599 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like I lost, but this wfm too. Did we want to file a bug to get this value from mozSettings? Or is it not worth it.
Attachment #8479599 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8479599 [details] [diff] [review]
> Patch 1 (v1) - Increase wait_for_homescreen timeout and add watch for new
> homescreen name
> 
> Review of attachment 8479599 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks like I lost, but this wfm too. Did we want to file a bug to get this
> value from mozSettings? Or is it not worth it.

https://bugzilla.mozilla.org/show_bug.cgi?id=1058089 is filed, I guess we can morph that bug to modify this change so we use mozSettings
https://hg.mozilla.org/mozilla-central/rev/43a4f13eeb31
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.