Closed Bug 1059108 Opened 7 years ago Closed 7 years ago
_handler _test .js,handled _call _test .js | Timed out after 120 seconds
b2g_ubuntu64_vm mozilla-inbound opt test gaia-unit on 2014-08-26 23:28:01 PDT for push 8328bc2054d1 slave: tst-linux64-spot-607 TEST-UNEXPECTED-TIMEOUT | callscreen/test/unit/handled_call_test.js | Timed out after 120 seconds https://tbpl.mozilla.org/php/getParsedLog.php?id=46835909&tree=Mozilla-Inbound
padenot: could this also be caused by the change for Bug 848954, seems it started there
Clearly our bad. We have a unit test where we were mocking only part of the WebAudio API and bad stuff happened. This should be much better.
Assignee: nobody → etienne
Attachment #8479894 - Flags: review?(anthony)
Summary: Intermittent handled_call_test.js | Timed out after 120 seconds → Intermittent calls_handler_test.js,handled_call_test.js | Timed out after 120 seconds
Comment on attachment 8479894 [details] [review] Gaia PR Stealing.
Attachment #8479894 - Flags: review?(anthony) → review+
https://github.com/mozilla-b2g/gaia/commit/5c517820066eb1e35395372f6e25c8707e3a0596 needinfo? nigelb or Tomcat to get this merged from b2g-inbound to m-c ASAP. Gu is near perma-fail on trunk right now.
Here's another patch for the handled_call_test intermittent
Attachment #8480463 - Flags: review?(etienne)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #28) > https://github.com/mozilla-b2g/gaia/commit/ > 5c517820066eb1e35395372f6e25c8707e3a0596 > > needinfo? nigelb or Tomcat to get this merged from b2g-inbound to m-c ASAP. > Gu is near perma-fail on trunk right now. included in https://tbpl.mozilla.org/?rev=70c1c94cfaec
Reopening for the second patch that needs to land still.
Comment on attachment 8480463 [details] [review] https://github.com/mozilla-b2g/gaia/pull/23414 Thanks!
There is a new failing test with this patch: https://tbpl.mozilla.org/?rev=df0e81d8cae86ba933f29aa6d6d71daac22451ad&tree=Gaia-Try So I've updated my patch with audio_competing_helper_test.js changes. New try https://tbpl.mozilla.org/?rev=31673d58db2163499854d64cee9060bad7fe2357&tree=Gaia-Try
Comment on attachment 8480463 [details] [review] https://github.com/mozilla-b2g/gaia/pull/23414 Green try \o/ Putting back in review since Étienne reviewed before my changes.
Attachment #8480463 - Flags: review+ → review?(etienne)
Comment on attachment 8480463 [details] [review] https://github.com/mozilla-b2g/gaia/pull/23414 r=me with the comment on github addressed. Let's discuss it IRL if it's unclear.
One more Try after addressing review comments: https://tbpl.mozilla.org/?rev=48f38cd368bb50155308aea7a2a5888dea3623be&tree=Gaia-Try
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.