1059118 - Request for a new repository for NFC emulation library

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for manifest

NFC emulation should be moved into a separate library to ease sharing between emulators in the future.

Please merge the attached pull request and setup the repository. The source repo is at

  https://github.com/tdz/platform_external_libnfcemu

Comment 1

[Pete Moore [:pmoore][:pete]]

Thanks Thomas!

The next steps will be:
  * mwu reviews the patch
  * when we get an r+ from mwu, we (Release Engineering) will set up the mirroring
  * when the mirroring is in place, mwu can merge the pull request

Regarding knowing which repository to mirror from and the new mirror to create to mirror to, all the information we need is in the patch you already provided (<project name="platform_external_libnfcemu" path="platform/external/libnfcemu" remote="b2g" />) so we don't require any further information.

From: https://github.com/tdz/b2g-manifest/blob/bug-1054934/emulator-jb.xml#L4 we see b2g remote is defined here:
https://github.com/tdz/b2g-manifest/blob/bug-1054934/base-jb.xml#L5
i.e.: the full repo url is git://github.com/mozilla-b2g/platform_external_libnfcemu

From here we see where the mirror should be made available on git.mozilla.org:
http://hg.mozilla.org/build/mozharness/file/26e71e92141f/configs/b2g_bumper/master.py#l75
i.e.: https://git.mozilla.org/b2g/platform_external_libnfcemu

Translating this from an https to an ssh url, this would be:
ssh://[e-mail]/b2g/platform_external_libnfcemu

So the mirroring required would be:
git://github.com/mozilla-b2g/platform_external_libnfcemu -> ssh://[e-mail]/b2g/platform_external_libnfcemu


Problem
=======

The source repository "git://github.com/mozilla-b2g/platform_external_libnfcemu" currently does not exist:
https://github.com/mozilla-b2g/?query=platform_external_libnfcemu

"We couldn't find any matching repositories."

When this github repository is available, and the b2g-manifests patch has been r+'d by mwu, we can set up the mirroring. At the moment the mirroring would fail, since the source repo does not exist, to mirror from.

Many thanks!
Pete

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I think there's some confusion (at least on my side). I have a repository in my Github account at

  https://github.com/tdz/platform_external_libnfcemu

It should be copied to Mozilla's official B2G account, probably

  https://github.com/mozilla-b2g/platform_external_libnfcemu

That repository will become the new 'upstream'.

Comment 3

[Pete Moore [:pmoore][:pete]]

Thanks Thomas.

Hal, if mwu approves the b2g-manifests patch, who can/should create https://github.com/mozilla-b2g/platform_external_libnfcemu?

Is any RelEng member entitled to do that?

Pete

Comment 4

[Pete Moore [:pmoore][:pete]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> I think there's some confusion (at least on my side). I have a repository in
> my Github account at
> 
>   https://github.com/tdz/platform_external_libnfcemu
> 
> It should be copied to Mozilla's official B2G account, probably
> 
>   https://github.com/mozilla-b2g/platform_external_libnfcemu
> 
> That repository will become the new 'upstream'.

Also for anyone else stumbling on this bug, this is worth a line or two of explanation:

The repo can live on mozilla-b2g github account, but RelEng systems build from git.mozilla.org repositories. Therefore a one-time import of this repository is required to make it available under the mozilla-b2g github account, and then subsequently the mirroring request takes care of actively keeping git.mozilla.org updated with changes as and when they land on mozilla-b2g github account, so that they remain in sync.

Comment 5

[Hal Wine [:hwine] use NI!]

Summing up the questions for mwu:

 - Are you okay adding https://github.com/tdz/platform_external_libnfcemu to the builds (r+ on patch can confirm that)

 - Any objection to moving the upstream repo to the mozilla-b2g account? Our systems run smoother if upstream is on a mozilla managed account in a case like this.

 - Assuming we're moving the repo -- do you want to do that or just let me know which teams should have access to the repo?

Comment 6

[Hal Wine [:hwine] use NI!]

(In reply to Pete Moore [:pete][:pmoore] from comment #3)
> Hal,
> 
> Is any RelEng member entitled to do that?

It's in the docs, but there may be additional issues depending on where upstream is located. I'll respond to this and comment 1 in more detail in email.

Comment 7

[Michael Wu [:mwu]]

(In reply to Hal Wine [:hwine] (use needinfo) from comment #5)
> Summing up the questions for mwu:
> 
>  - Are you okay adding https://github.com/tdz/platform_external_libnfcemu to
> the builds (r+ on patch can confirm that)
> 
>  - Any objection to moving the upstream repo to the mozilla-b2g account? Our
> systems run smoother if upstream is on a mozilla managed account in a case
> like this.
> 

We'll want to move it upstream to mozilla-b2g.

>  - Assuming we're moving the repo -- do you want to do that or just let me
> know which teams should have access to the repo?

I'll move/copy it. BTW, I'm going to rename the repo to libnfcemu since the platform_external prefixing is more for repos mirrored from upstream.

Comment 8

[Michael Wu [:mwu]]

https://github.com/mozilla-b2g/libnfcemu now available.

Comment 9

[Hal Wine [:hwine] use NI!]

in production with 
  http://hg.mozilla.org/users/hwine_mozilla.com/repo-sync-configs/rev/9313f3a94b78

Comment 10

[Hal Wine [:hwine] use NI!]

https://git.mozilla.org/b2g/libnfcemu.git available

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The repository seems to have been copied, but it's not been added to the manifest. Is there anything required from my side to make progress here?

Comment 12

[Michael Wu [:mwu]]

You have a PR that adds it, but it needs to be updated to pull from https://github.com/mozilla-b2g/libnfcemu.

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8479671 [details]
Github pull request for manifest

OK, updated the PR's manifest to include the correct repository.

Comment 14

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/b2g-manifest/commit/c41253a1a95fc96ed8b3633a9a41780bb70e1771