Closed Bug 1059135 Opened 5 years ago Closed 5 years ago

"Transfer Protocol" header is not localized/localizable

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: flod, Assigned: gasolin)

References

Details

(Whiteboard: [p=1])

Attachments

(2 files)

Attached image usb.png
As asked on dev-gaia, please test your patches with pseudo-locales
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Gaia

Again, the string used as data-l10n-id for the header (transferProtocol-header) is not the string exposed in the .properties file (transferProtocol).
Thanks for finding it. also fix search panel string
Attachment #8479709 - Flags: review?(ejchen)
The Search part should be in bug 1057696 (since it's not the only issue), unless you want to fix everything here.
Comment on attachment 8479709 [details] [review]
pull request redirect to github

Thanks Fred, let's keep translation for Search intact and leave it at the bug as :flod mentioned. 

r+ !
Attachment #8479709 - Flags: review?(ejchen) → review+
removed search part, merged to master https://github.com/mozilla-b2g/gaia/commit/553f7969241ddcd592ac53f25a46230475b87c49

thanks!
Assignee: nobody → gasolin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.