Closed
Bug 1059164
Opened 10 years ago
Closed 10 years ago
Ensure the zoom-out animation is async
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S3 (29aug)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | fixed |
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
1.53 KB,
patch
|
etienne
:
review+
|
Details | Diff | Splinter Review |
As explained in the CSS files, the animation needs to be < 4096px on both dimensions (width and height), where px is calculated by |window.devicePixelRatio * frame.[width/height] * scale.
I changed it from 5 to 3 in order to works correctly on the flame which has a devicePixelRatio of 1.5 with a height of 569. Previously the total number was:
1.5 * 569 * 5 = 4267.5 which is > 4096.
Now it is:
1.5 * 569 * 3 = 2560 which is < 4096
I choose 3 so it will also works for device with a higher pixel ratio and a higher resolution.
Attachment #8479733 -
Flags: review?(etienne)
Comment 1•10 years ago
|
||
Comment on attachment 8479733 [details] [diff] [review]
ensure.async.animation.patch
Review of attachment 8479733 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8479733 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 2•10 years ago
|
||
PR at https://github.com/mozilla-b2g/gaia/pull/23479
Seems like I can't merge today...
Keywords: checkin-needed
Comment 3•10 years ago
|
||
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•