1059171 - Make the editor field of nsIMsgCompose read-write

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Jonathan Protzenko [:protz]]

Attachment: patch-set-editor

Per the reasons exposed in https://mail.mozilla.org/pipermail/tb-planning/2014-August/003380.html I would like to make the editor field in nsIMsgCompose settable.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 8479747 [details] [diff] [review]
patch-set-editor

I believe you need to change the uuid of the interface.

This should be probably be reviewed by Neil as its more his area.

Comment 2

[[e-mail]]

Comment on attachment 8479747 [details] [diff] [review]
patch-set-editor

With the uuid change, seems reasonable, I guess. While you're there, would you mind removing the unused and now superfluous clearEditor method?

Comment 3

[Jonathan Protzenko [:protz]]

Attachment: patch-set-editor-2

Here's the patch that I'm about to checkin.

Comment 4

[Jonathan Protzenko [:protz]]

... and that I will checkin once the tree reopens. Thanks for the fast reviews.

Comment 5

[Mark Banner (:standard8)]

:protz, given the follow-ups in tb-planning, do we still want to land this?

Comment 6

[Jonathan Protzenko [:protz]]

I think we do. Doing this:
- allows ehsan to move back nsIEditor to being builtinclass;
- fixes the use-case of Conversations.

Unless we really want to refactor nsIMsgCompose, this is the best we can do right now.

Comment 7

[Jonathan Protzenko [:protz]]

Adding checkin-needed because I probably won't be able to hang out in #maildev for a while, so if any good soul wants to check this in, this would be great (Conversations is currently broken without this patch).

The patch applies cleanly.

Thanks,

~ jonathan

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/e147bfa72d66 -> FIXED