Closed Bug 1059192 Opened 10 years ago Closed 10 years ago

Permanent orange: TEST-UNEXPECTED-FAIL | test_searchSuggest.js | contains an error

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(thunderbird33 fixed, thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird33 --- fixed
thunderbird34 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch Add the prefSplinter Review
This has been failing for a while (it fails on aurora):

TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_searchSuggest.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
[4596] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/slave/tb-c-aurora-osx64-d-0000000000/build/mozilla/toolkit/crashreporter/nsExceptionHandler.cpp, line 2185
System JS : ERROR (null):0 - uncaught exception: 2147500037
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file /builds/slave/talos-slave/test/build/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_searchSuggest.js contains an error
Diagnostic: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]
JS frame :: resource://gre/modules/SearchSuggestionController.jsm:26 :: anonymous :: line 32
JS frame :: @/builds/slave/talos-slave/test/build/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_searchSuggest.js:11:0
JS frame :: /builds/slave/talos-slave/test/build/xpcshell/head.js:510 :: loadTailFile :: line 6
JS frame :: _load_files@/builds/slave/talos-slave/test/build/xpcshell/head.js:526:2
JS frame :: /builds/slave/talos-slave/test/build/xpcshell/head.js:393 :: _execute_test :: line 2
JS frame :: @-e:1:0

There's two parts to this, one is to define the pref, the second is to fix the test with an m-c patch as it assumes the pref is true.
Attachment #8479792 - Flags: review?(Pidgeot18)
Depends on: 1059195
Attachment #8479792 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/bd6c6a502465
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
Comment on attachment 8479792 [details] [diff] [review]
Add the pref

[Triage Comment]
Test-only change
Attachment #8479792 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.