1059234 - Import sim contacts message not displayed on FTU after importing contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Viorela Ioia [:viorela]]

No message is displayed in Import contacts page from, after the import is done. 

#STR:
1. Launch FTU app
2. Go through the FTU steps until you reach Import contacts page
3. Tap Sim card 
4. Wait for contacts to be imported from SIM

#Expected results:
A message that says how many contacts have been imported is displayed after the import has finished (as when importing contacts from SIM in Contacts app)

#Actual results:
No message is displayed after the import has finished

Last working build:
Device firmware (date) 	23 Jul 2014 07:25:46
Device firmware (incremental) 	eng.cltbld.20140723.102536
Device firmware (release) 	4.3
Device identifier 	flame
Gaia date 	21 Aug 2014 22:47:00
Gaia revision 	02e61f605471
Gecko build 	20140821231216
Gecko revision 	a6475a163389
Gecko version 	34.0a1

First failing: Device firmware (date) 	23 Jul 2014 07:25:46
Device firmware (incremental) 	eng.cltbld.20140723.102536
Device firmware (release) 	4.3
Device identifier 	flame
Gaia date 	21 Aug 2014 23:11:54
Gaia revision 	e99b0c0b7074
Gecko build 	20140821232752
Gecko revision 	3b687b257f7c
Gecko version 	34.0a1

Comment 1

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 2

[Cody Roesch [:croesch]]

This bug repro's on: Flame 2.1, OpenC 2.1

Actual Results: No message appears after importing contacts from SIM in the FTU.

Repro Rate: 2/2

Environmental Variables:
Device: Flame Master
BuildID: 20140826180827
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Open_C Master
BuildID: 20140826125726
Gaia: ea93363a8c424d65a9ad91438ce6961377a20f98
Gecko: f9bfe115fee5
Version: 34.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

------------------------------------------------
------------------------------------------------

This bug does NOT repro on: Flame 2.0, Flame 1.4

Actual Result: Imported X contacts message is seen after import occurs.

Repro Rate: 0/4 attempts

Environmental Variables:
Device: Flame 2.0
BuildID: 20140826142630
Gaia: d72f8ad53448aed577c01ff6e11d958463f261e7
Gecko: 2a18149b3ae8
Version: 32.0 (2.0) 
Firmware Version: v123
-------------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20140825062151
Gaia: cf9d74da6653efeb43d9653e81c61aa00e693a67
Gecko: cdcb73d0febc
Version: 30.0 (1.4) 
Firmware Version: v123

Comment 3

[Joshua Mitchell (Inactive)]

QA-Wanted Triage Analysis - I would not block on this issue - while the message is useful I would not consider it integral - there are obvious signs of contacts being imported as well as a # being reported on the loading bar (ex.  5/20), so this message just seems like a bonus.

Comment 4

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

(In reply to Joshua Mitchell [:Joshua_M] from comment #3)
> QA-Wanted Triage Analysis - I would not block on this issue - while the
> message is useful I would not consider it integral - there are obvious signs
> of contacts being imported as well as a # being reported on the loading bar
> (ex.  5/20), so this message just seems like a bonus.

This actually causes one of our automated tests to go down though, so I actually do think we need to block here. Otherwise, we will lose on-device coverage.

QA blocking regression.

Comment 5

[Jason Smith [:jsmith]]

Adding window wanted to help with doing a gaia/gecko swap with the above builds.

Comment 6

[Jason Smith [:jsmith]]

Actually disregard - I'm pretty sure this is regressed by this commit:

https://github.com/mozilla-b2g/gaia/commit/246f4c5725721e35810926f037d2651e630651cd

Comment 7

[Jason Smith [:jsmith]]

Broken by bug 1050684.

Comment 8

[Jason Smith [:jsmith]]

Adrian is on PTO, so I'm adding a needinfo on the reviewer to see if he can help look into this regression, so we can get our on device automation back online.

Comment 9

[Cristian Rodriguez (:crdlc)]

Adrian is on PTO only today but I gonna try to fi it if I have the chance today

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

There is not mystery, import_status_data.js was loaded synchronously and the Adrian's patch changed it to use LazyLoad lib. We thought that ImportStatusData was only used by us but this component was used too in misc.js so simply I have restored the import as it was previously (before Adrian's patch). Thanks

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8481134 [details]
Github pull request

Thanks Cristian!

Comment 12

[Cristian Rodriguez (:crdlc)]

Thanks when Gaia will open I gonna merge it

Comment 14

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/12d69254a1caa80015a63de47dceb07a323f5783

Comment 15

[Gregor Wagner [:gwagner]]

Cristian did you already uplift the patch? I see you marked it fixed for 2.1 but I dont see the link.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

It landed on master before the uplift.

Comment 17

[Cristian Rodriguez (:crdlc)]

If I am not wrong I merged it before creating the 2.1 branch. Is it not correct? Thanks a lot

(In reply to Gregor Wagner [:gwagner] from comment #15)
> Cristian did you already uplift the patch? I see you marked it fixed for 2.1
> but I dont see the link.

Comment 18

[[:RJ]]

this issue is verified fixed in Flame 2.2 Master KK (319mb) (Full Flash)

after phone reset FTU when importing contacts for the sim there is now a notification that lets the user know that the contacts were imported and also how many were imported. 

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 19

[[:RJ]]

In previous comment "this issue is verified fixed in Flame 2.2 Master KK (319mb) (Full Flash)" was meant to say "this issue is verified fixed in Flame 2.1 KK (319mb) (Full Flash)"