Closed Bug 1059243 Opened 5 years ago Closed 5 years ago

Test failure 'getEntity: Entity - privatebrowsingpage.perwindow.* has been found' in /testPrivateBrowsing/*

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

defect

Tracking

(firefox34 fixed)

RESOLVED FIXED
Tracking Status
firefox34 --- fixed

People

(Reporter: andrei, Assigned: andrei)

References

Details

(Keywords: regression, Whiteboard: [mozmill-test-failure])

Attachments

(1 file)

3.92 KB, patch
AndreeaMatei
: review+
whimboo
: review+
Details | Diff | Splinter Review
We have 2 failures. Looks like some entities have changed.

Test: /testPrivateBrowsing/testAboutPrivateBrowsing.js
Failure: getEntity: Entity - privatebrowsingpage.perwindow.issueDesc.normal has been found - got 'null' 

Test: /testPrivateBrowsing/testOpenClosePBKeyboardShortcut.js
Failure: getEntity: Entity - privatebrowsingpage.perwindow.description has been found - got 'null'

mc pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dc352a7bf234&tochange=0753f7b93ab7

Bug 1009370 is the regressor.
Attached patch 1.patchSplinter Review
Quick fix, I updated the DTD entities and the node selectors.

I do not like all selectors I had to use, but some elements are lacking proper identification. To improve this we will need to update the about:privatebrowsing page with more relevant hooks (if we deem it important).

With the current selectors the tests might break again if the page content gets reordered.
Attachment #8479856 - Flags: review?(andreea.matei)
Comment on attachment 8479856 [details] [diff] [review]
1.patch

Review of attachment 8479856 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Maybe we could get a feedback if they plan to update the pages further?
Attachment #8479856 - Flags: review?(hskupin)
Attachment #8479856 - Flags: review?(andreea.matei)
Attachment #8479856 - Flags: review+
Comment on attachment 8479856 [details] [diff] [review]
1.patch

Review of attachment 8479856 [details] [diff] [review]:
-----------------------------------------------------------------

I agree regarding accessibility. Feel free to file new bugs. To get our tests fixed it looks fine to me.
Attachment #8479856 - Flags: review?(hskupin) → review+
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/5c2689122d12 (default)
Thanks Andrei!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.