1059245 - Update tests and framework to use the new Browser app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

At this time tests are still using the old browser app, but once that one is deleted or the PR from Bug 1059224 lands the tests will fail.

The browser page object and the tests that use it need to be updated according to the new functionality.

The new Browser app can be found at:
https://github.com/mozilla-b2g/gaia/tree/master/apps/search

Comment 1

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23467

Comment 2

[Viorela Ioia [:viorela]]

Comment on attachment 8481172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23467

Please r? again when you're done updating the test. Thanks!

Comment 3

[Zac C (:zac)]

Comment on attachment 8481172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23467

I am r+ on this when the test_browser_bookmark is fixed. I see it's failing still but at a different point in the test. 

I can see in the HTML source that the bookmark is installed though.

Comment 4

[Viorela Ioia [:viorela]]

Comment on attachment 8481172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23467

r+

Comment 5

[Florin Strugariu [:Bebe]]

Comment on attachment 8481172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23467

Looks OK

Comment 6

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/d433078d18d98e86ab132a5ece49831885659b44

v2.1:
https://github.com/mozilla-b2g/gaia/commit/e7ac3a51932f7f7a5b5a6935dcaad1343b7c5fa5

Comment 7

[Diego Wilson [:diego]]

Hi Zac,

Looks like one of the endurance tests missed this update. Shall I open a new bug to add it too?

https://github.com/mozilla-b2g/gaia/blob/v2.1/tests/python/gaia-ui-tests/gaiatest/tests/endurance/test_endurance_browser_cell.py#L10

Comment 8

[Diego Wilson [:diego]]

Clear NI and move to bug 1074314