1059332 - Update strings for 2.1 FxA error flows

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Guilherme Gonçalves [:ggp]]

We need to update/include new strings that are going to be used for 2.1, as per the specification at https://mozilla.app.box.com/s/7of2b8ampjzjgwir8s5f , before the 2.1 string freeze.

Comment 1

[vkrishnamoorthy]

[Blocking Requested - why for this release]: We need to land the strings before string freeze

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

There's a lot of old comments in bug 998489, so I'm going to attach the PR here, and we'll hope that the settings folks have time for it on Monday.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 23508

Hi Arthur,

Would you mind taking a quick glance at this PR? We have some error-handling bugs for Find My Device that require new strings; since the strings are due before the bugs, and the string deadline is 9/1, I'd like to land them in this PR :-)

Thanks very much,

Jared

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Also, since I will not be working on Monday, could you please set checkin-needed if this is r+? Thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8481553 [details] [review]
Github PR 23508

LGTM, thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: f7bb48246e80f51dbc867392058a86e1eecd6175