Closed Bug 1059376 Opened 6 years ago Closed 5 years ago

DevTools themes - Arrow color doesn't match the info bar color

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: aljullu, Assigned: aljullu, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

From Bug 975804 Comment 17:
> The arrow color doesn't match the info bar color, it's very subtle,
> but noticeable (hsl(210,2%,22%) should be hsl(214,13%,24%)).
Attached patch bug1059376.patch (obsolete) — Splinter Review
That was an easy patch! :)
Attachment #8522360 - Flags: review?(bgrinstead)
Comment on attachment 8522360 [details] [diff] [review]
bug1059376.patch

Review of attachment 8522360 [details] [diff] [review]:
-----------------------------------------------------------------

> That was an easy patch! :)

You should have known it wouldn't be this easy ;).  There was a push literally 2 hours ago to fx-team that moved this file.  See Bug 1096575 - the new location is toolkit/devtools/server/actors/highlighter.css.
Attachment #8522360 - Flags: review?(bgrinstead)
Depends on: 1096575
Attached patch bug1059376.patchSplinter Review
Let's see now then! :)
Attachment #8522360 - Attachment is obsolete: true
Attachment #8523501 - Flags: review?(bgrinstead)
The patch looks good, but since the infobar font-size has been made smaller. It makes sense to me to make the arrow size smaller as well.
Comment on attachment 8523501 [details] [diff] [review]
bug1059376.patch

Review of attachment 8523501 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8523501 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/integration/fx-team/rev/395c82ee15f4
Component: Developer Tools → Developer Tools: Inspector
Whiteboard: [fixed-in-fx-team]
(In reply to Tim Nguyen [:ntim] from comment #4)
> The patch looks good, but since the infobar font-size has been made smaller.
> It makes sense to me to make the arrow size smaller as well.

Let's do that in a follow up bug.  I'm not sure if that arrow size was meant to match the other popups or something, but I agree that it could be a bit smaller.
(In reply to Brian Grinstead [:bgrins] from comment #7)
> (In reply to Tim Nguyen [:ntim] from comment #4)
> > The patch looks good, but since the infobar font-size has been made smaller.
> > It makes sense to me to make the arrow size smaller as well.
> 
> Let's do that in a follow up bug.  I'm not sure if that arrow size was meant
> to match the other popups or something, but I agree that it could be a bit
> smaller.

Should I open a bug for that?
(In reply to Albert Juhé from comment #8)
> (In reply to Brian Grinstead [:bgrins] from comment #7)
> > (In reply to Tim Nguyen [:ntim] from comment #4)
> > > The patch looks good, but since the infobar font-size has been made smaller.
> > > It makes sense to me to make the arrow size smaller as well.
> > 
> > Let's do that in a follow up bug.  I'm not sure if that arrow size was meant
> > to match the other popups or something, but I agree that it could be a bit
> > smaller.
> 
> Should I open a bug for that?

Sure
https://hg.mozilla.org/mozilla-central/rev/395c82ee15f4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.