1059404 - [mozrunner] Accept a dump save path when checking for crashes in DeviceRunner

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It's currently only possible to set the dump save path via an environment variable. Passing a path to the check_for_crashes in DeviceRunner would allow us to save the dumps for attaching to Treeherder reports as artifacts.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I'm going to set bug 1059248 as a blocker just because it touches the same code, as is close to landing.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Accept a dump save path when checking for crashes. v1.0

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=051293b1934f

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8481598 [details] [diff] [review]
Accept a dump save path when checking for crashes. v1.0

Review of attachment 8481598 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!

::: testing/mozbase/mozrunner/mozrunner/base/device.py
@@ +129,4 @@
>          test_name = test_name or self.last_test
>          dump_dir = self.device.pull_minidumps()
>          crashed = BaseRunner.check_for_crashes(
> +            self, dump_directory=dump_dir, dump_save_path=dump_save_path,

nit: put each variable on its own line if you're going to format it this way.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Accept a dump save path when checking for crashes. v1.1

Carrying r+

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/296fe203e6fd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/296fe203e6fd