Closed Bug 1059404 Opened 7 years ago Closed 7 years ago

[mozrunner] Accept a dump save path when checking for crashes in DeviceRunner

Categories

(Testing :: Mozbase, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

Attachments

(1 file, 1 obsolete file)

It's currently only possible to set the dump save path via an environment variable. Passing a path to the check_for_crashes in DeviceRunner would allow us to save the dumps for attaching to Treeherder reports as artifacts.
I'm going to set bug 1059248 as a blocker just because it touches the same code, as is close to landing.
Blocks: 1059248
No longer blocks: 1059248
Depends on: 1059248
Comment on attachment 8481598 [details] [diff] [review]
Accept a dump save path when checking for crashes. v1.0

Review of attachment 8481598 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!

::: testing/mozbase/mozrunner/mozrunner/base/device.py
@@ +129,4 @@
>          test_name = test_name or self.last_test
>          dump_dir = self.device.pull_minidumps()
>          crashed = BaseRunner.check_for_crashes(
> +            self, dump_directory=dump_dir, dump_save_path=dump_save_path,

nit: put each variable on its own line if you're going to format it this way.
Attachment #8481598 - Flags: review?(ahalberstadt) → review+
Carrying r+
Attachment #8481598 - Attachment is obsolete: true
Attachment #8482812 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/296fe203e6fd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.