Closed Bug 1059460 Opened 10 years ago Closed 6 years ago

You need to clobber only the OS X opt build when you hit "package-manifest:439: File missing (whatever jarred file someone just removed)" ("make[2]: *** [postflight_all] Error 2"/"make: *** [automation/package] Error 2")

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: RyanVM, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure) 

Been seeing these for a couple of days now. Some sort of race?

https://tbpl.mozilla.org/php/getParsedLog.php?id=46875046&tree=Fx-Team

OS X 10.7 fx-team build on 2014-08-27 11:12:50 PDT for push 10346f72cdcb
slave: bld-lion-r5-080

mkdir -p /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/dist/universal/
rm -f /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/x86_64/dist/universal
ln -s /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/dist/universal /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/x86_64/dist/universal
make -C /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/browser/installer \
	   PKG_SKIP_STRIP=1 stage-package
OMNIJAR_NAME=omni.ja \
	/builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/fx-team-osx64-0000000000000000/build/toolkit/mozapps/installer/packager.py -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container -DMOZ_SHARED_MOZGLUE=1 -DNECKO_WIFI -DDLL_PREFIX=lib -DDLL_SUFFIX=.dylib -DBIN_SUFFIX= -DMOZ_FOLD_LIBS=1 -DAPPNAME=FirefoxNightly.app -DBINPATH=/FirefoxNightly.app/Contents/MacOS -DMOZ_ICU_VERSION=52 -DMOZ_ICU_DBG_SUFFIX= -DCLANG_CXX \
		--format omni \
		--removals /builds/slave/fx-team-osx64-0000000000000000/build/browser/installer/removed-files.in \
		 \
		 \
		 \
		 \
		--optimizejars \
		--unify /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/../x86_64/dist \
		package-manifest ../../dist ../../dist/universal/firefox \
		
Error: /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/browser/installer/package-manifest:439: File missing in ../../dist: FirefoxNightly.app/Contents/MacOS/browser/chrome/browser/skin/classic/browser/Privacy-48.png
Error: /builds/slave/fx-team-osx64-0000000000000000/build/obj-firefox/i386/browser/installer/package-manifest:439: File missing in ../../dist: FirefoxNightly.app/Contents/MacOS/browser/chrome/browser/skin/classic/browser/aboutPrivateBrowsing.css
Traceback (most recent call last):
  File "/builds/slave/fx-team-osx64-0000000000000000/build/toolkit/mozapps/installer/packager.py", line 402, in <module>
    main()
  File "/builds/slave/fx-team-osx64-0000000000000000/build/toolkit/mozapps/installer/packager.py", line 354, in main
    copier.add(mozpack.path.join(binpath, 'removed-files'), removals)
  File "/tools/python/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/builds/slave/fx-team-osx64-0000000000000000/build/python/mozbuild/mozpack/errors.py", line 129, in accumulate
    raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
make[3]: *** [stage-package] Error 1
make[2]: *** [postflight_all] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2
I have a similar in https://tbpl.mozilla.org/?tree=Fx-Team&rev=e0638ce22c6e

The error is same, but the file in question is not aboutPrivateBrowsing.css, but SettingsQueue.jsm
Temporarily disabled bld-lion-r5-091 before I clobbered every trunk tree, in hopes that someone will look at its busted fx-team opt objdir, though maybe this current case from bug 1061888 removing some files from browser/extensions/shumway/ isn't the same as the SettingsQueue.jsm case where the file was removed from moz.build but not removed from the tree, or the original case where bug 1009370 moved aboutPrivateBrowsing.css from skin to content and stopped jarring Privacy-48.png, but didn't remove it.

At any rate, that's what's going on here: removing jarred files requires a clobber on OS X universal builds.
Blocks: clobber
You're right, that was silly of me. We can always find a new bustage when someone actually wants to look.
(In reply to TBPL Robot from comment #34)
> submit_timestamp: 2014-12-29T17:36:09
> log:
> https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-
> inbound&job_id=4987728
> repository: mozilla-inbound
> who: wkocher[at]mozilla[dot]com
> machine: bld-lion-r5-003
> buildname: OS X 10.7 mozilla-inbound build
> revision: a90291c04e5b
> 
> IOError: [Errno 2] No such file or directory:
> '/var/folders/ly/7r7cl9tj5sg8c0j11hszlq2000000w/T/tmp4WNwCE.zip'
> make[3]: *** [stage-package] Error 1
> make[2]: *** [postflight_all] Error 2
> make[1]: *** [realbuild] Error 2
> make: *** [build] Error 2
> Return code: 2
> 'mach build' did not run successfully. Please check log for errors.
> Running post_fatal callback...
> Exiting -1
> # TBPL FAILURE #
> # TBPL FAILURE #

Nope, not this bug.
Summary: Intermittent "package-manifest:439: File missing ... Privacy-48.png, aboutPrivateBrowsing.css" ("make[2]: *** [postflight_all] Error 2") → You need to clobber only the OS X opt build when you hit "package-manifest:439: File missing ... Privacy-48.png, aboutPrivateBrowsing.css, (whatever jarred file someone just removed)" ("make[2]: *** [postflight_all] Error 2")
From today's occurrence on m-i, it would seem to be related to universal builds not removing files properly on both ends of the universal build.
... which I now realized is in the bug title.
Summary: You need to clobber only the OS X opt build when you hit "package-manifest:439: File missing ... Privacy-48.png, aboutPrivateBrowsing.css, (whatever jarred file someone just removed)" ("make[2]: *** [postflight_all] Error 2") → You need to clobber only the OS X opt build when you hit "package-manifest:439: File missing (whatever jarred file someone just removed)" ("make[2]: *** [postflight_all] Error 2"/"make: *** [automation/package] Error 2")
No longer relevant on branches we care about.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.