1059465 - Remove uploaded files after processing

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect)

Description

[Rob Hudson [:robhudson]]

In many cases we leave behind the source files of previews, etc. Currently the tmp/preview/ folder is 15G.

This bug should do 2 things:

1. Update code to be better about removing these uploads when we are done processing them. Look for anything creating paths based on TMP_PATH (e.g., mkt/developers/forms.py has `upload_path = os.path.join(settings.TMP_PATH, 'preview', ...`. Follow the code path and remove this file after we're done.

2. Write a cron job to purge files older than a week from some of these sub-folders. Review uses of TMP_PATH to find the appropriate ones.

Comment 1

[Rob Hudson [:robhudson]]

This removes the creation of tmp files during feed serialization:
https://github.com/mozilla/zamboni/commit/6a20e87

Comment 2

[Rob Hudson [:robhudson]]

Clean up of preview images when we're done:
https://github.com/mozilla/zamboni/commit/dfb0276 

That covers all of item (1) in comment 0. All other uses of TMP_PATH clean up after themselves well.

Next up is item (2). I'll add this to `mkt_gc`.

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/d924446