Closed Bug 1059474 Opened 7 years ago Closed 7 years ago

update certificate exception handling in lightning to deal with bug 940506

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1046328 +++

Bug 940506 removed the nsIRecentBadCerts interface and implementation, which means that the old way of adding certificate exceptions do not work. I thought there was a bug on this already, but I guess not. What needs to happen is everywhere Thunderbird opens the certificate exception override dialog, it needs to pass along the nsISSLStatus from the connection that failed. See for reference the patch in bug 1025332.

---

Attached patch is untested, but I see no reason it wouldn't work. That's what I did in bug 1046328.
Attachment #8480082 - Flags: review?(philipp)
Comment on attachment 8480082 [details] [diff] [review]
bugXXX_cert_handling_update_calendar.patch

Review of attachment 8480082 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, also untested. I'm fine with pushing this and figuring out if it works afterwards. Looks simple enough. r=philipp
Attachment #8480082 - Flags: review?(philipp) → review+
https://hg.mozilla.org/comm-central/rev/051d4e9d6d92 -> FIXED
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.5
Target Milestone: 3.5 → 3.7
Comment on attachment 8480082 [details] [diff] [review]
bugXXX_cert_handling_update_calendar.patch

Bug 940506 was fixed for mozilla33. Do we need to port this back to comm-aurora (Lightning 3.6) and comm-beta (Lightning 3.5)?
Attachment #8480082 - Flags: approval-calendar-beta?(philipp)
Attachment #8480082 - Flags: approval-calendar-aurora?(philipp)
Attachment #8480082 - Flags: approval-calendar-beta?(philipp)
Attachment #8480082 - Flags: approval-calendar-beta+
Attachment #8480082 - Flags: approval-calendar-aurora?(philipp)
Attachment #8480082 - Flags: approval-calendar-aurora+
Can confirm this bug on Thunderbird 35.0a1 nightly from today.

When we use a proxy server (charles http proxy) we are given the interface to confirm the security exception. The certificate does get stored in the certificate list, but it doesn't work and the dialog pops-up repeatedly until I cancel it.
Please file a new bug, with steps+details to reproduce. Prior to this bug fix you would not get the possibility to add the exception. Failure to actually use the cert is something different.
I actually asked Evert to mention it here in case its related. On the other hand it also happens in 3.1.1, so it might be a different bug. I don't mind it being handled in a new bug though.

Magnus, don't forget to push this to down to gecko 33.
Keywords: checkin-needed
Whiteboard: [checkin-needed: comm-aurora, comm-beta]
Pushed to https://hg.mozilla.org/releases/comm-aurora/rev/8bd828dc08ff
Whiteboard: [checkin-needed: comm-aurora, comm-beta] → [checkin-needed: comm-beta]
Target Milestone: 3.7 → 3.6
Pushed to https://hg.mozilla.org/releases/comm-beta/rev/77eb6f57422b
Keywords: checkin-needed
Whiteboard: [checkin-needed: comm-beta]
Target Milestone: 3.6 → 3.5
You need to log in before you can comment on or make changes to this bug.