1059482 - [Browser] Going to settings through the network unavailable error page can cause non-functional buttons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Description:
If user tries to go to a webpage with no network connection, taps on the "Settings" icon when prompted with an error and then opens and closes a Rocketbar search, the "Settings" page will become non-functional. 

Repro Steps:
1)  Updated Flame to Build ID: 20140827040203
2)  Disable WiFi and data connection.
3)  Open the browser app.
4)  Type in a web address and tap return on the keyboard.
5)  When prompted that the network connection is unavailable, tap on the "Settings" icon.
6)  Tap on the Rocketbar search bar on top of the settings page.
7)  Start typing in letters on the keyboard and tap the "Settings" icon that appears below the rocketbar. (nothing will happen)
8)  Tap on the "close" button. 
9)  Tap "Done" on the settings page. (nothing will happen)
10) Try tapping on "WifI" and "cellular & Data" buttons. 

Actual:
Buttons on the settings page will become unresponsive.

Expected:
All options on the settings page should function without issue. 

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140827040203
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Repro frequency: 100%
Link to failed test case: Found while exploratory testing. 
See attached: Video, Logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SettingsPage.txt

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue also occurs on the Flame 2.1(512mb) and Open C 2.1 devices.

The settings page buttons will become unresponsive following the STR from above.

Flame 2.1(512mb)

Environmental Variables:
Device: Flame Master 
BuildID: 20140827040203
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1

Environmental Variables:
Device: Open_C Master
Build ID: 20140827040203
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

-------------------------------------------------------------------------------------------------

This issue does not occur on the Flame 2.0(319mb), Open C 2.0, Flame 1.4(319mb) or the Open C 1.4.

The user flow is different. The user cannot go directly to rocketbar from the settings page. 

Flame 2.0(319mb)

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140827000204
Gaia: d72f8ad53448aed577c01ff6e11d958463f261e7
Gecko: 2a18149b3ae8
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open C 2.0

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140827000204
Gaia: d72f8ad53448aed577c01ff6e11d958463f261e7
Gecko: 2a18149b3ae8
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 1.4(319mb)

Environmental Variables:
Device: Flame 1.4 (319mb)
BuildID: 20140827003002
Gaia: 05653cb12d324649687dad3eeb2ea373a2ad84d4
Gecko: 7ad0648b8447
Version: 30.0 (1.4)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Open C 1.4

Environmental Variables:
Device: Open_C 1.4
BuildID: 20140827003002
Gaia: 05653cb12d324649687dad3eeb2ea373a2ad84d4
Gecko: 7ad0648b8447
Version: 30.0 (1.4)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 3

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

Nominating this because the user will not only come across unresponsive icons, but the whole settings page will become unresponsive and the user must force close the app to get out of it.

Comment 4

[Candice Serran (:cserran)]

Blocker justification: unresponsive icons

Comment 5

[Kevin Grandon :kgrandon]

Should be fixed by 1060045, verifying now.

Comment 6

[Kevin Grandon :kgrandon]

Possibly also bug 1062198, so adding a dependency.

Comment 7

[Kevin Grandon :kgrandon]

Not solved by 1062198, investigating this..

Comment 8

[Kevin Grandon :kgrandon]

I thought you could tap on the text and not just the icon =/ Seems like we could have better UX, but that's a different bug.

This is solved via bug 1062198 after all.

Comment 9

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This bug has been verified fixed in Flame 2.1 and Flame 2.2

When the user has no network connection and is brought to the settings page from selecting the "Check Settings" button, all settings can be changed without error. Even when typing within the rocketbar, first, the wifi, cellular & Data, and airplane mode settings all work correctly.

Flame 2.1

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 10

[Kevin Grandon :kgrandon]

A test will be added for this in bug 1062198, so testsuite+ for now to remove it from our tracking. (It's covered by a unit test already, but we should still add an integration test).