1059490 - mark more classes as final

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: mark more classes MOZ_FINAL

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8480112 [details] [diff] [review]
mark more classes MOZ_FINAL

Review of attachment 8480112 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the HAVE_VISIBILITY changes reverted.

::: memory/mozalloc/mozalloc_abort.h
@@ +14,5 @@
>  // do nothing: it's been defined to __declspec(dllexport) by
>  // mozalloc*.cpp on platforms where that's required
>  #elif defined(XP_WIN)
>  #  define MOZALLOC_EXPORT __declspec(dllimport)
> +#elif __GNUC__ || __clang__

Um, different patch?

::: memory/mozalloc/mozalloc_oom.h
@@ +14,5 @@
>  // do nothing: it's been defined to __declspec(dllexport) by
>  // mozalloc*.cpp on platforms where that's required
>  #elif defined(XP_WIN)
>  #  define MOZALLOC_EXPORT __declspec(dllimport)
> +#elif defined(__GNUC__) || defined(__clang__)

Here too.

::: mfbt/Types.h
@@ +39,5 @@
>   */
>  #if defined(WIN32)
>  #  define MOZ_EXPORT   __declspec(dllexport)
>  #else /* Unix */
> +#  if __GNUC__ || __clang__

Here too.

Comment 3

[Trevor Saunders (:tbsaunde)]

> r=me with the HAVE_VISIBILITY changes reverted.

erph, yeah that stuff is a silly mistake on my part.

Comment 4

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26c4989e824c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/26c4989e824c