Closed Bug 1059490 Opened 6 years ago Closed 6 years ago

mark more classes as final

Categories

(Core :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

No description provided.
Attachment #8480112 - Flags: review?(nfroyd)
Comment on attachment 8480112 [details] [diff] [review]
mark more classes MOZ_FINAL

Review of attachment 8480112 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the HAVE_VISIBILITY changes reverted.

::: memory/mozalloc/mozalloc_abort.h
@@ +14,5 @@
>  // do nothing: it's been defined to __declspec(dllexport) by
>  // mozalloc*.cpp on platforms where that's required
>  #elif defined(XP_WIN)
>  #  define MOZALLOC_EXPORT __declspec(dllimport)
> +#elif __GNUC__ || __clang__

Um, different patch?

::: memory/mozalloc/mozalloc_oom.h
@@ +14,5 @@
>  // do nothing: it's been defined to __declspec(dllexport) by
>  // mozalloc*.cpp on platforms where that's required
>  #elif defined(XP_WIN)
>  #  define MOZALLOC_EXPORT __declspec(dllimport)
> +#elif defined(__GNUC__) || defined(__clang__)

Here too.

::: mfbt/Types.h
@@ +39,5 @@
>   */
>  #if defined(WIN32)
>  #  define MOZ_EXPORT   __declspec(dllexport)
>  #else /* Unix */
> +#  if __GNUC__ || __clang__

Here too.
Attachment #8480112 - Flags: review?(nfroyd) → review+
> r=me with the HAVE_VISIBILITY changes reverted.

erph, yeah that stuff is a silly mistake on my part.
https://hg.mozilla.org/mozilla-central/rev/26c4989e824c
Assignee: nobody → trev.saunders
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.