1059589 - testBug1057248.js is going to perma-fail when Gecko 34 merges to Aurora

Status: VERIFIED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Merge day is Tuesday, 2-September.

https://tbpl.mozilla.org/php/getParsedLog.php?id=46896129&tree=Try

15:46:01     INFO -  FAIL - asm.js/testBug1057248.js
15:46:01  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "")
15:46:01     INFO -  INFO exit-status     : 3
15:46:01     INFO -  INFO timed-out       : False
15:46:01     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:02     INFO -  FAIL - asm.js/testBug1057248.js
15:46:02  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--ion-eager --ion-offthread-compile=off")
15:46:02     INFO -  INFO exit-status     : 3
15:46:02     INFO -  INFO timed-out       : False
15:46:02     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:02     INFO -  FAIL - asm.js/testBug1057248.js
15:46:02  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
15:46:02     INFO -  INFO exit-status     : 3
15:46:02     INFO -  INFO timed-out       : False
15:46:02     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:02     INFO -  FAIL - asm.js/testBug1057248.js
15:46:02  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--baseline-eager")
15:46:02     INFO -  INFO exit-status     : 3
15:46:02     INFO -  INFO timed-out       : False
15:46:02     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:03     INFO -  FAIL - asm.js/testBug1057248.js
15:46:03  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--baseline-eager --no-fpu")
15:46:03     INFO -  INFO exit-status     : 3
15:46:03     INFO -  INFO timed-out       : False
15:46:03     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:03     INFO -  FAIL - asm.js/testBug1057248.js
15:46:03  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--no-baseline --no-ion")
15:46:03     INFO -  INFO exit-status     : 3
15:46:03     INFO -  INFO timed-out       : False
15:46:03     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This is a ginormous test, so while I'm sure it just needs some |if (typeof SharedArrayBuffer !== "undefined")| love like the other SharedArrayBuffer-using tests have, I'm not entirely sure where exactly it needs to go. Luke, can you whip something up soon given the time pressure we're under here? :)

Comment 2

[Luke Wagner [:luke]]

Forwarding to Lars.

Comment 3

[Lars T Hansen [:lth]]

It should be enough to add these as the first two lines in the file:

if (!this.SharedArrayBuffer || !isAsmJSCompilationAvailable())
  quit();

(I'll be back with more if that fails to work in testing.)

Comment 4

[Lars T Hansen [:lth]]

That guard seems to work fine in local testing.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: skip the test if SharedArrayBuffer isn't supported

Try likes it and r=lth over IRC.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b83ffe131420

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b83ffe131420

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Green on Try now :)