testBug1057248.js is going to perma-fail when Gecko 34 merges to Aurora

VERIFIED FIXED in mozilla34

Status

()

defect
--
critical
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla34
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
Merge day is Tuesday, 2-September.

https://tbpl.mozilla.org/php/getParsedLog.php?id=46896129&tree=Try

15:46:01     INFO -  FAIL - asm.js/testBug1057248.js
15:46:01  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "")
15:46:01     INFO -  INFO exit-status     : 3
15:46:01     INFO -  INFO timed-out       : False
15:46:01     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:02     INFO -  FAIL - asm.js/testBug1057248.js
15:46:02  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--ion-eager --ion-offthread-compile=off")
15:46:02     INFO -  INFO exit-status     : 3
15:46:02     INFO -  INFO timed-out       : False
15:46:02     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:02     INFO -  FAIL - asm.js/testBug1057248.js
15:46:02  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
15:46:02     INFO -  INFO exit-status     : 3
15:46:02     INFO -  INFO timed-out       : False
15:46:02     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:02     INFO -  FAIL - asm.js/testBug1057248.js
15:46:02  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--baseline-eager")
15:46:02     INFO -  INFO exit-status     : 3
15:46:02     INFO -  INFO timed-out       : False
15:46:02     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:03     INFO -  FAIL - asm.js/testBug1057248.js
15:46:03  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--baseline-eager --no-fpu")
15:46:03     INFO -  INFO exit-status     : 3
15:46:03     INFO -  INFO timed-out       : False
15:46:03     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
15:46:03     INFO -  FAIL - asm.js/testBug1057248.js
15:46:03  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/asm.js/testBug1057248.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined (code 3, args "--no-baseline --no-ion")
15:46:03     INFO -  INFO exit-status     : 3
15:46:03     INFO -  INFO timed-out       : False
15:46:03     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/asm.js/testBug1057248.js:126:0 ReferenceError: SharedArrayBuffer is not defined
Assignee

Comment 1

5 years ago
This is a ginormous test, so while I'm sure it just needs some |if (typeof SharedArrayBuffer !== "undefined")| love like the other SharedArrayBuffer-using tests have, I'm not entirely sure where exactly it needs to go. Luke, can you whip something up soon given the time pressure we're under here? :)
Severity: normal → critical
Flags: needinfo?(luke)
Forwarding to Lars.
Flags: needinfo?(luke) → needinfo?(lhansen)
It should be enough to add these as the first two lines in the file:

if (!this.SharedArrayBuffer || !isAsmJSCompilationAvailable())
  quit();

(I'll be back with more if that fails to work in testing.)
Flags: needinfo?(lhansen)
That guard seems to work fine in local testing.
Assignee

Comment 5

5 years ago
Try likes it and r=lth over IRC.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8480675 - Flags: review+
Assignee

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b83ffe131420
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Assignee

Comment 8

5 years ago
Green on Try now :)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.