Closed Bug 1059625 Opened 9 years ago Closed 9 years ago

Detach MediaSource upon decoder shutdown

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Detach MediaSource upon decoder shutdown
3.13 KB, patch
cajbir
: review+
Details | Diff | Splinter Review 
If the decoder shuts down (due to an error, for example), detach the MediaSource to stop the MediaSource trying to use the MediaSourceDecoder's resources.

Inspired by bug 1059569.

        Attachment #8480325 -
        Flags: review?(cajbir.bugzilla)

    
  

        Attachment #8480325 -
        Flags: review?(cajbir.bugzilla) → review+

    
  

        Attachment #8480325 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8480960 [details] [diff] [review]
Detach MediaSource upon decoder shutdown

This broke a crashtest; need to handle detaching twice.

        Attachment #8480960 -
        Flags: review?(cajbir.bugzilla)

    
  

        Attachment #8480960 -
        Flags: review?(cajbir.bugzilla) → review+

    
    

    
  
(In reply to Matthew Gregan [:kinetik] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/169a90f344da

That was for:

https://tbpl.mozilla.org/php/getParsedLog.php?id=46989177&full=1&branch=mozilla-inbound#error1

Which is a null deref because the CC already cleared the pointers.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8a69a71936ce
https://hg.mozilla.org/mozilla-central/rev/169a90f344da
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34

          You need to log in
          before you can comment on or make changes to this bug.