Detach MediaSource upon decoder shutdown

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

(Blocks: 1 bug)

Trunk
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
If the decoder shuts down (due to an error, for example), detach the MediaSource to stop the MediaSource trying to use the MediaSourceDecoder's resources.

Inspired by bug 1059569.
(Assignee)

Comment 1

4 years ago
Created attachment 8480325 [details] [diff] [review]
Detach MediaSource upon decoder shutdown.
Attachment #8480325 - Flags: review?(cajbir.bugzilla)

Updated

4 years ago
Attachment #8480325 - Flags: review?(cajbir.bugzilla) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 8480960 [details] [diff] [review]
Detach MediaSource upon decoder shutdown
(Assignee)

Updated

4 years ago
Attachment #8480325 - Attachment is obsolete: true
(Assignee)

Comment 3

4 years ago
Comment on attachment 8480960 [details] [diff] [review]
Detach MediaSource upon decoder shutdown

This broke a crashtest; need to handle detaching twice.
Attachment #8480960 - Flags: review?(cajbir.bugzilla)

Updated

4 years ago
Attachment #8480960 - Flags: review?(cajbir.bugzilla) → review+
(Assignee)

Comment 6

4 years ago
(In reply to Matthew Gregan [:kinetik] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/169a90f344da

That was for:

https://tbpl.mozilla.org/php/getParsedLog.php?id=46989177&full=1&branch=mozilla-inbound#error1

Which is a null deref because the CC already cleared the pointers.
https://hg.mozilla.org/mozilla-central/rev/8a69a71936ce
https://hg.mozilla.org/mozilla-central/rev/169a90f344da
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.