1059633 - Evite.com "Reply" button (in Yes/Maybe/No RSVP "dialog") sticks out of its container

Status: RESOLVED DUPLICATE of bug 1059167

(Core :: Layout: Form Controls, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit this evite for a test event that I made:
    http://www.evite.com/event/0207B6YDQC2YAQJQKEPEFZW5GAQ3WA
 2. Click the "Yes", "Maybe", or "No" buttons
 3. Look at the "Reply" button at the bottom-right of the "dialog" that pops up from the button.

ACTUAL RESULTS:
 The "Reply" button sticks off the right side of its dialog.

EXPECTED RESULTS:
 The "Reply" button should stay inside its dialog.

m-c regression range:
Last good revision: daa84204a11a (2014-08-25)
First bad revision: dc352a7bf234 (2014-08-26)

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=daa84204a11a&tochange=dc352a7bf234

(mozregression is narrowing it further using inbound builds...)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 2

[Daniel Holbert [:dholbert]]

regression range on inbound:
Last good revision: daa84204a11a
First bad revision: 156f1bee4139
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=daa84204a11a&tochange=156f1bee4139

(This is still a bit wide of a range, I think because we had bustage on inbound during some of the intervening time, which was eventually fixed by backout.)

Comment 3

[Daniel Holbert [:dholbert]]

The first obvious guess there would be the change to layout/forms/nsHTMLButtonControlFrame.cpp, which is:
https://hg.mozilla.org/mozilla-central/rev/ee3477f5614b
Jonathan Kew — bug 1046950 pt 1 - additional/modified APIs on LogicalSize. r=smontagu

Comment 4

[Daniel Holbert [:dholbert]]

(which means this may end up being a dupe of bug 1059167...)

Comment 5

[Daniel Holbert [:dholbert]]

Yup, I've confirmed that bug 1059167's patch (attachment 8479906 [details] [diff] [review]) fixes this. Duping.