Closed Bug 1059653 Opened 10 years ago Closed 10 years ago

Check for non-null connection before trying to null out its _result attr

Categories

(Cloud Services Graveyard :: Server: Sync, defect)

Product:
Cloud Services Graveyard
Component:
Server: Sync
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rfkelly, Assigned: rfkelly)

Details

(Whiteboard: [qa?])

Attachments

(1 file)

syncstorage-check-null-conn.diff
623 bytes, patch
telliott
: review+
Details | Diff | Splinter Review 
After restarting the db on one of the stage sync nodes, we started getting tracebacks saying:

  AttributeError(\"'NoneType' object has no attribute '_result'\",)

It appears to be the code from Bug 1052258, which does not expect to receive a None for the connection object.  Trivial patch attached to check for this case.
Assignee: nobody → rfkelly

        Attachment #8480377 -
        Flags: review?(telliott)

        Attachment #8480377 -
        Flags: review?(telliott) → review+
Whiteboard: [qa?]

    
    

    
  
https://github.com/mozilla-services/server-syncstorage/commit/0a551f441ab8db063fee2bc95c15762567c772e4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
server-syncstorage 1.5.9 is now in Production
Status: RESOLVED → VERIFIED

    
  
Product: Cloud Services → Cloud Services Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: