Check for non-null connection before trying to null out its _result attr

VERIFIED FIXED

Status

Cloud Services
Server: Sync
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
After restarting the db on one of the stage sync nodes, we started getting tracebacks saying:

  AttributeError(\"'NoneType' object has no attribute '_result'\",)

It appears to be the code from Bug 1052258, which does not expect to receive a None for the connection object.  Trivial patch attached to check for this case.
(Assignee)

Comment 1

4 years ago
Created attachment 8480377 [details] [diff] [review]
syncstorage-check-null-conn.diff
Assignee: nobody → rfkelly
Attachment #8480377 - Flags: review?(telliott)
Attachment #8480377 - Flags: review?(telliott) → review+
Whiteboard: [qa?]
(Assignee)

Comment 2

4 years ago
https://github.com/mozilla-services/server-syncstorage/commit/0a551f441ab8db063fee2bc95c15762567c772e4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
server-syncstorage 1.5.9 is now in Production
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.