Provide a sensible default timeout for wait_for_b2g_ready

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This method accepts a timeout argument without a default value. I think it would be a good idea to set a default of 60 seconds, which is what we use when starting B2G.
(Assignee)

Comment 1

3 years ago
Created attachment 8480411 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23407
Attachment #8480411 - Flags: review?(zcampbell)

Comment 2

3 years ago
Comment on attachment 8480411 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23407

low risk, r+ .. 60 is fine, the only time I've seen us hit that is when it's a legitimate fail.
Attachment #8480411 - Flags: review?(zcampbell) → review+
(Assignee)

Comment 3

3 years ago
Landed in:
https://github.com/mozilla-b2g/gaia/commit/08714b0e1e9c30710f103dc1729217f437da2133
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.