1059687 - Webapps.jsm:3552 - test for equality (==) mistyped as assignment (=)?

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Mats Palmgren (inactive)]

STR
Using a local debug Firefox build on Linux64:
./mach mochitest-plain content/html/content/test/

ACTUAL RESULT
In the log output:
INFO System JS : WARNING resource://gre/modules/Webapps.jsm:3552 - test for equality (==) mistyped as assignment (=)?

Comment 1

[[:fabrice] Fabrice Desré]

Can paste the part around this line from your $OBJDIR/dist/bin/modules/Webapps.jsm ? This file has a bunch of preprocessing and I only have b2g builds around.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: suppresses "test for equality mistyped as assignment" warning

Presumably it's this one.

Comment 3

[[:fabrice] Fabrice Desré]

right. Ted?

Comment 4

[Mats Palmgren (inactive)]

myk's patch fixed it in my local build -- the affected line is 3706, so the warning
is just slightly off :-/

Comment 5

[Ted Clancy [:tedders1]]

I can confirm that the relevant line is intentionally an assignment, and not an equality test mistyped as an assignment. 

The compiler is merely trying to besmirch my reputation.

myk's patch looks good.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/fx-team/rev/7a6e3931a0f1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a6e3931a0f1