tooltool should output informational and progress messages with default options

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
20 days ago

People

(Reporter: nthomas, Assigned: simone)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
It's clearly intended to be logging.INFO by default, but something isn't quite right. Simone says he's working on a patch already, so that's another win for complaining about things in IRC :-).
(Assignee)

Comment 1

3 years ago
Created attachment 8480457 [details] [diff] [review]
tooltool_01

Since logger debug level was not set and default is warning, no logging message was passed to the handler (whose log level was correctly set depending on parsed args).

Now the logger debug level is set depending on parsed arg, and the handler is simply configure to log any log record received from the logger.
Attachment #8480457 - Flags: review?(nthomas)
(Assignee)

Comment 2

3 years ago
Created attachment 8480461 [details] [diff] [review]
tooltool_02

"ch.setLevel(logging.DEBUG)" in previous patch is not needed, since by default handlers log everything
Attachment #8480457 - Attachment is obsolete: true
Attachment #8480457 - Flags: review?(nthomas)
Attachment #8480461 - Flags: review?(nthomas)
(Reporter)

Updated

3 years ago
Attachment #8480461 - Flags: review?(nthomas) → review+
(Assignee)

Comment 3

3 years ago
Pushed to https://github.com/mozilla/build-tooltool/commit/0cea231be9db6a0b66fea7873265f88265c56517 and http://hg.mozilla.org/build/puppet/rev/968bfccdf2fd
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
In production https://hg.mozilla.org/build/puppet/rev/2c418569ddd0
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.