Closed Bug 1059707 Opened 5 years ago Closed 5 years ago

Don't print a deprecation warning for theme XBL binding documents

Categories

(Core :: XUL, defect, major)

33 Branch
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- affected
firefox34 --- affected

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: addon-compat, regression)

Attachments

(1 file)

If a third-party theme has its own XBL binding then a deprecation warning is printed. This is because theme documents don't have the system principal, so we try to do a permission check on them.
Actually it's not just third-party themes, it affects the default themes too. For instance, the Places organiser will trigger this on Linux, while on Windows you just need a window with a radiobutton. (The default Mac theme currently has no XBL.)
Severity: normal → major
What is the case here. We're appending an element to what kind of document? XBL document, which
has what kind of URL?
(In reply to Olli Pettay from comment #2)
> What is the case here. We're appending an element to what kind of document?
> XBL document, which has what kind of URL?

chrome://global/skin/globalBindings.xml in the radiobutton case.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8480555 - Flags: review?(bugs)
Attachment #8480555 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/88b588fb2039
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.