1059707 - Don't print a deprecation warning for theme XBL binding documents

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

If a third-party theme has its own XBL binding then a deprecation warning is printed. This is because theme documents don't have the system principal, so we try to do a permission check on them.

Comment 1

[[e-mail]]

Actually it's not just third-party themes, it affects the default themes too. For instance, the Places organiser will trigger this on Linux, while on Windows you just need a window with a radiobutton. (The default Mac theme currently has no XBL.)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

What is the case here. We're appending an element to what kind of document? XBL document, which
has what kind of URL?

Comment 3

[[e-mail]]

(In reply to Olli Pettay from comment #2)
> What is the case here. We're appending an element to what kind of document?
> XBL document, which has what kind of URL?

chrome://global/skin/globalBindings.xml in the radiobutton case.

Comment 4

[[e-mail]]

Attachment: Proposed patch

Comment 5

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88b588fb2039

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88b588fb2039