1059709 - Thunderbird trunk doesn't build -- incompatibility with mozilla PLDHashTable

Status: RESOLVED DUPLICATE of bug 1059551

(Thunderbird :: Build Config, defect)

Description

[Jonathan Kamens]

Freshly checked out trunk, clean build:

10:30.79 In file included from /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:17:0:
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h: In member function ‘TokenHash::operator int()’:
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h:95:41: error: ‘PLDHashTable’ has no member named ‘entryStore’
10:30.79      operator int() { return mTokenTable.entryStore != NULL; }
10:30.79                                          ^
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In constructor ‘TokenEnumeration::TokenEnumeration(PLDHashTable*)’:
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:127:25: error: ‘PLDHashTable’ has no member named ‘entrySize’
10:30.79      :   mEntrySize(table->entrySize),
10:30.79                          ^
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:128:28: error: ‘PLDHashTable’ has no member named ‘entryCount’
10:30.79          mEntryCount(table->entryCount),
10:30.79                             ^
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:130:27: error: ‘PLDHashTable’ has no member named ‘entryStore’
10:30.79          mEntryAddr(table->entryStore)
10:30.79                            ^
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:132:54: error: ‘PL_DHASH_TABLE_CAPACITY’ was not declared in this scope
10:30.79      uint32_t capacity = PL_DHASH_TABLE_CAPACITY(table);
10:30.79                                                       ^
10:30.79 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In member function ‘BaseToken* TokenEnumeration::nextToken()’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:149:41: error: ‘PL_DHASH_ENTRY_IS_LIVE’ was not declared in this scope
10:30.80          if (PL_DHASH_ENTRY_IS_LIVE(entry)) {
10:30.80                                          ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In destructor ‘virtual TokenHash::~TokenHash()’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:196:21: error: ‘PLDHashTable’ has no member named ‘entryStore’
10:30.80      if (mTokenTable.entryStore)
10:30.80                      ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In member function ‘nsresult TokenHash::clearTokens()’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:206:21: error: ‘PLDHashTable’ has no member named ‘entryStore’
10:30.80      if (mTokenTable.entryStore)
10:30.80                      ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In member function ‘void TokenHash::visit(bool (*)(BaseToken*, void*), void*)’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:272:35: error: ‘PLDHashTable’ has no member named ‘entryCount’
10:30.80      if (visitCount != mTokenTable.entryCount) {
10:30.80                                    ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:273:148: error: ‘PLDHashTable’ has no member named ‘entryCount’
10:30.80        PR_LOG(BayesianFilterLogModule, PR_LOG_ERROR, ("visitCount != entryCount!: %d vs %d", visitCount, mTokenTable.entryCount));
10:30.80                                                                                                                                                     ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In member function ‘uint32_t TokenHash::countTokens()’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:279:22: error: ‘PLDHashTable’ has no member named ‘entryCount’
10:30.80    return mTokenTable.entryCount;
10:30.80                       ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In member function ‘void nsBayesianFilter::classifyMessage(Tokenizer&, const char*, nsTArray<unsigned int>&, nsTArray<unsigned int>&, nsIJunkMailClassificationListener*, nsIMsgTraitClassificationListener*, nsIMsgTraitDetailListener*)’:
10:30.80 Warning: -Wunused-variable in /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: unused variable ‘rv’
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1595:20: warning: unused variable ‘rv’ [-Wunused-variable]
10:30.80            nsresult rv = setAnalysis(token, traitIndex, distance, prob);
10:30.80                     ^
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp: In member function ‘uint32_t TokenHash::countTokens()’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:280:1: error: control reaches end of non-void function [-Werror=return-type]
10:30.80  }
10:30.80  ^
10:30.80 In file included from /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:17:0:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h: In member function ‘TokenHash::operator int()’:
10:30.80 /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h:95:63: error: control reaches end of non-void function [-Werror=return-type]
10:30.80      operator int() { return mTokenTable.entryStore != NULL; }
10:30.80                                                                ^
10:30.80 cc1plus: some warnings being treated as errors
10:30.80 In the directory  /home/jik/build/thunderbird/comm-central/obj-x86_64-unknown-linux-gnu/mailnews/extensions/bayesian-spam-filter/src
10:30.80 The following command failed to execute properly:
10:30.80 c++ -o nsBayesianFilter.o -c -I../../../../dist/stl_wrappers -I../../../../dist/system_wrappers -include /home/jik/build/thunderbird/comm-central/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DZLIB_INTERNAL -DOSTYPE="Linux3.15.8-200.fc20" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -I/home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src -I. -I../../../../dist/include -I/home/jik/build/thunderbird/comm-central/obj-x86_64-unknown-linux-gnu/dist/include/nspr -I/home/jik/build/thunderbird/comm-central/obj-x86_64-unknown-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MP -MF .deps/nsBayesianFilter.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Werror=type-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -freorder-blocks -Os -fomit-frame-pointer /home/jik/build/thunderbird/comm-central/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
10:30.80 gmake[4]: *** [nsBayesianFilter.o] Error 1
10:30.81 gmake[3]: *** [mailnews/extensions/bayesian-spam-filter/src/target] Error 2

Comment 1

[Magnus Melin [:mkmelin]]

This was fixed with https://hg.mozilla.org/comm-central/rev/2779bb21f0e2 I think, the remaining part should be bug 1057912.

Comment 2

[Magnus Melin [:mkmelin]]

Sorry, bug 1059551.