1059710 - OdinMonkey - SIMD: add support for comparisons

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

This is high priority for the Intel SIMD demo.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: odin-simd-comparisons.patch

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8480494 [details] [diff] [review]
odin-simd-comparisons.patch

Review of attachment 8480494 [details] [diff] [review]:
-----------------------------------------------------------------

So the SIMD spec doesn't provide <= et al for int32x4?  Is that motivated by the hardware?

::: js/src/asmjs/AsmJSValidate.cpp
@@ +4632,5 @@
>      return true;
>  }
>  
>  static bool
> +CheckBinarySimd(FunctionCompiler &f, ParseNode *call, AsmJSSimdType simdType,

I reviewed bug 1059733 before this, but the change I suggested (un-templating CheckBinarySimd and switching on the op at the end) would I think avoid some of this code duplication as well.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Odin SIMD: add support for comparisons

Oh yes, that's way nicer! carrying forward r+.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: bug1059710.patch

Forgot to factor the switch

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c32ca9dc0726

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c32ca9dc0726