Closed Bug 1059721 Opened 6 years ago Closed 6 years ago
Fix localization comments for plural forms in webrtc
I realized it after the landing from bug 1057006. I know it's painful, but for plural form we need the entire localization comment http://hg.mozilla.org/mozilla-central/file/ffc10f34de13/browser/locales/en-US/chrome/browser/webrtcIndicator.properties#l32 Also one separated comment for each string. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Use_proper_plural_forms
(In reply to Francesco Lodolo [:flod] (offline from Aug 31 to Sep 7) from comment #0) > I realized it after the landing from bug 1057006. > > I know it's painful, but for plural form we need the entire localization > comment > http://hg.mozilla.org/mozilla-central/file/ffc10f34de13/browser/locales/en- > US/chrome/browser/webrtcIndicator.properties#l32 I'm happy to fix something here, but what do you mean by "entire localization comment" ? > Also one separated comment for each string. > > https://developer.mozilla.org/en-US/docs/Mozilla/Localization/ > Localization_best_practices#Use_proper_plural_forms you mean that rather than the * notation you want something like: http://hg.mozilla.org/mozilla-central/file/ffc10f34de13/browser/locales/en-US/chrome/browser/browser.properties#l509 ?
We need a localization comment like this on each string # LOCALIZATION NOTE (stringid): # Semicolon-separated list of plural forms. See: # http://developer.mozilla.org/en/docs/Localization_and_Plurals This form of comment is used by tool to identify plural forms. I don't think multiple stringids in one comment would work, that's why I said "one per string", even if painful to look at.
(In reply to Francesco Lodolo [:flod] (offline from Aug 31 to Sep 7) from comment #2) > I don't think multiple stringids in one comment would work Can you elaborate on "work"? Why are we using them everywhere if they don't "work"? Is this issue specific to a particular tool? (which?)
Attachment #8480503 - Flags: review?(francesco.lodolo)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Tools for localizations parse comments to display them near the string. This is one of the tools that do that: http://mozilla.locamotion.org/ "Won't work": I simply doubt that such tools will be able to correctly match "getUserMedia.*" (or list of IDs) to all the strings starting with "getUserMedia.". That explains the part "match a string to its comment". Plural forms are a special case: how do you recognize a plural form? You can't search for ";", because that's a common character that could be used in a string. So we settle on "parse the comment associated to the string". Compare-locales is another tool that relies on these comments to display warnings and errors, and it's the tool running all l10n-dashboards http://hg.mozilla.org/l10n/compare-locales
Comment on attachment 8480503 [details] [diff] [review] update l10n comments, Review of attachment 8480503 [details] [diff] [review]: ----------------------------------------------------------------- Perfect :-)
Attachment #8480503 - Flags: review?(francesco.lodolo) → review+
Iteration: --- → 34.3
Points: --- → 1
Marco, can you add this to the spreadsheet? Thanks!
Added to IT 34.3.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.