1059733 - OdinMonkey - SIMD: add support for bitwise ops

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

This is high priority for the Mandelbrot demo.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Patch + tests

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8480528 [details] [diff] [review]
Patch + tests

Review of attachment 8480528 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

::: js/src/asmjs/AsmJSValidate.cpp
@@ +4644,5 @@
> +                MSimdBinaryArith::Operation op, MDefinition **def, Type *type)
> +{
> +    JS_ASSERT_IF(simdType == AsmJSSimdType_int32x4,
> +                 op != MSimdBinaryArith::Mul && op != MSimdBinaryArith::Div);
> +    return CheckBinarySimd<MSimdBinaryArith>(f, call, simdType, op, def, type);

Instead of all this, could we just pass the 'global' all the way through and switch at the end of CheckBinarySimd?

Comment 3

[Marty Rosenberg [:mjrosenb]]

(In reply to Benjamin Bouvier [:bbouvier] from comment #0)
> This is high priority for the Mandelbrot demo.

I'm not actually sure this is true. The only bitwise op used in the mandelbrot demo is i4_and, but it is being used on a bool, to change the set {-1,0} into {1,0} to be passed into i4_add.
so
count = i4_add(count, i4_and(mi4, ones_i4))
can just be i4_sub(count, mi4)
and no bitops are needed. (it'll probably also run a couple of cycles faster)

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: bug1059733.patch

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1eb94f3ebf22

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1eb94f3ebf22