Closed Bug 1059798 Opened 6 years ago Closed 6 years ago
Enable Loop client in early beta or earlier
Loop in Fx33 will be disabled unless we make a small change to the milestone.txt file. We'd like to keep it on in early Beta and disable it before it goes to release.
This switches the ifdef to track for early betas only. I'll request release driver approval once I've got review.
Attachment #8480597 - Flags: review?(ted)
Comment on attachment 8480597 [details] [diff] [review] Enable Loop on development builds up to early betas. Review of attachment 8480597 [details] [diff] [review]: ----------------------------------------------------------------- Not sure why this is r?me (am I a peer for this file?) but you can have r=me for what it's worth. :)
Attachment #8480597 - Flags: review?(ted) → review+
Comment on attachment 8480597 [details] [diff] [review] Enable Loop on development builds up to early betas. Requesting approval to land in trunk and on aurora as per the rules. Approval Request Comment [Feature/regressing bug #]: No specific bug, Loop enabling on Firefox 33 [User impact if declined]: Loop will not be enabled in the early Firefox 33 betas, where we want more users to start trying Loop. [Describe test coverage new/current, TBPL]: No changes to test coverage, this is just enabling the pref in FF beta and earlier. This has been in test on nightly and aurora for the last 6 weeks [Risks and why]: The desktop management and Loop teams want to get more testing on the Early betas in FF 33. [String/UUID change made/needed]: None
Attachment #8480597 - Flags: approval-mozilla-aurora?
Please land that in m-c, I will approve the uplift for aurora right after to make sure it is in beta1. Lawrence, I approve that on your behalf for 34.
Assignee: nobody → standard8
Target Milestone: --- → mozilla34
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8480597 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tracy, can you please make sure this gets verified in the first Beta? The UX is not complete in 33 but users should be able to activate it and have 1:1 calls with friends. Some basic dogfooding should suffice.
I've added this verification as a specific item in the smoketest section of the Fx33 test plan.
Florin, can you please make sure this gets verified as part of Firefox 34b1 sign off? The Firefox Hello button should appear in the customize panel by default on new profiles. I believe the button should stay in the toolbar in profiles which have already customized the button to be on the toolbar. Thanks
Testing was performed for Loop with Firefox 34 Beta 1 build 2 (BuildID=20141014134955), on Windows 7 x64, Windows 8.1 x86, Mac OSX 10.9.5, Ubuntu 14.04 x64: - the Hello button displays in the Customize panel by default (if loop.throttled is set to false) - if a user from Aurora customizes position for the button in the toolbar, and then uses the same profile in Beta 1, if loop.throttled is true then it's unlikely to get the button. However is the loop.throttled option is overridden in pref.js to false, then the user will correctly see the Hello button at the same position in the toolbar as on Aurora Tests run can be found at: https://moztrap.mozilla.org/results/cases/?filter-run=5613. Marking as Verified on 34.
You need to log in before you can comment on or make changes to this bug.