1059798 - Enable Loop client in early beta or earlier

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Maire Reavy [:mreavy]]

Loop in Fx33 will be disabled unless we make a small change to the milestone.txt file.  We'd like to keep it on in early Beta and disable it before it goes to release.

Comment 1

[Mark Banner (:standard8)]

Attachment: Enable Loop on development builds up to early betas.

This switches the ifdef to track for early betas only. I'll request release driver approval once I've got review.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8480597 [details] [diff] [review]
Enable Loop on development builds up to early betas.

Review of attachment 8480597 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure why this is r?me (am I a peer for this file?) but you can have r=me for what it's worth. :)

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8480597 [details] [diff] [review]
Enable Loop on development builds up to early betas.

Requesting approval to land in trunk and on aurora as per the rules.

Approval Request Comment
[Feature/regressing bug #]: No specific bug, Loop enabling on Firefox 33
[User impact if declined]: Loop will not be enabled in the early Firefox 33 betas, where we want more users to start trying Loop.
[Describe test coverage new/current, TBPL]: No changes to test coverage, this is just enabling the pref in FF beta and earlier. This has been in test on nightly and aurora for the last 6 weeks
[Risks and why]: The desktop management and Loop teams want to get more testing on the Early betas in FF 33.
[String/UUID change made/needed]: None

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Please land that in m-c, I will approve the uplift for aurora right after to make sure it is in beta1.

Lawrence, I approve that on your behalf for 34.

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/bab83a083c3a

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bab83a083c3a

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d62fe065592e

Comment 8

[u279076]

Tracy, can you please make sure this gets verified in the first Beta? The UX is not complete in 33 but users should be able to activate it and have 1:1 calls with friends. Some basic dogfooding should suffice.

Comment 9

[Tracy Walker [:tracy]]

I've added this verification as a specific item in the smoketest section of the Fx33 test plan.

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Marking as verified as per tests performed on Firefox 33 beta 1.

Comment 12

[u279076]

Florin, can you please make sure this gets verified as part of Firefox 34b1 sign off? The Firefox Hello button should appear in the customize panel by default on new profiles. I believe the button should stay in the toolbar in profiles which have already customized the button to be on the toolbar.

Thanks

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Testing was performed for Loop with Firefox 34 Beta 1 build 2 (BuildID=20141014134955), on Windows 7 x64, Windows 8.1 x86, Mac OSX 10.9.5, Ubuntu 14.04 x64:  
- the Hello button displays in the Customize panel by default (if loop.throttled is set to false) 
- if a user from Aurora customizes position for the button in the toolbar, and then uses the same profile in Beta 1, if loop.throttled is true then it's unlikely to get the button. However is the loop.throttled option is overridden in pref.js to false, then the user will correctly see the Hello button at the same position in the toolbar as on Aurora

Tests run can be found at: https://moztrap.mozilla.org/results/cases/?filter-run=5613.

Marking as Verified on 34.