1059813 - [I/O] Cleanup |UnixSocketRawData|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

|UnixSocketRawData| should provide a clean interface for access to it's internals.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1059813: Wrap socket I/O operations in |UnixSocketRawData

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in |KeyStore|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in NFC helpers

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in RIL helpers

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [05] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in Bluetooth

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [06] Bug 1059813: Protect access to fields of |UnixSocketRawData|

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8480611 [details] [diff] [review]
[05] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in Bluetooth

Review of attachment 8480611 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8480606 [details] [diff] [review]
[02] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in |KeyStore|

Review of attachment 8480606 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but :chucklee owns the keystore stuff so probably want him to have a look.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #8)

> LGTM, but :chucklee owns the keystore stuff so probably want him to have a
> look.

Oh, thanks. I wasn't sure about keystore.

And thanks Chuck, for handling this so quickly.

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0b7a62175398
https://hg.mozilla.org/integration/b2g-inbound/rev/7bd0ecf96e59
https://hg.mozilla.org/integration/b2g-inbound/rev/d08a91fee65a
https://hg.mozilla.org/integration/b2g-inbound/rev/ab4056a1aa06
https://hg.mozilla.org/integration/b2g-inbound/rev/f991f546dbcd
https://hg.mozilla.org/integration/b2g-inbound/rev/cffeecd46cad

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=cffeecd46cad

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out per Thomas' IRC request.
https://hg.mozilla.org/integration/b2g-inbound/rev/927da4815ef9

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1059813: Wrap socket I/O operations in |UnixSocketRawData (v2)

Changes since v1:

  - rebased onto bug 1062754

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [06] Bug 1059813: Protect access to fields of |UnixSocketRawData| (v2)

Changes since v1:

  - rebased onto bug 1062754

Comment 14

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I had to fix bug 1062754 first. Landing these patches again.

https://hg.mozilla.org/integration/b2g-inbound/rev/5e1f40db0989
https://hg.mozilla.org/integration/b2g-inbound/rev/26df995c1141
https://hg.mozilla.org/integration/b2g-inbound/rev/38867ab63da7
https://hg.mozilla.org/integration/b2g-inbound/rev/903d7d5824ce
https://hg.mozilla.org/integration/b2g-inbound/rev/34cf2c6ebc74
https://hg.mozilla.org/integration/b2g-inbound/rev/e8ba4019d6a3

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=e8ba4019d6a3

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e1f40db0989
https://hg.mozilla.org/mozilla-central/rev/26df995c1141
https://hg.mozilla.org/mozilla-central/rev/38867ab63da7
https://hg.mozilla.org/mozilla-central/rev/903d7d5824ce
https://hg.mozilla.org/mozilla-central/rev/34cf2c6ebc74
https://hg.mozilla.org/mozilla-central/rev/e8ba4019d6a3