Closed Bug 1059813 Opened 8 years ago Closed 8 years ago

[I/O] Cleanup |UnixSocketRawData|

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S4 (12sep)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(6 files, 2 obsolete files)

3.48 KB, patch
qdot
: review+
chucklee
: review+
Details | Diff | Splinter Review
1.81 KB, patch
allstars.chh
: review+
Details | Diff | Splinter Review
1.13 KB, patch
vicamo
: review+
Details | Diff | Splinter Review
26.74 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
7.49 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
4.45 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
|UnixSocketRawData| should provide a clean interface for access to it's internals.
Attachment #8480609 - Flags: review?(vyang) → review+
Attachment #8480608 - Flags: review?(allstars.chh) → review+
Comment on attachment 8480611 [details] [diff] [review]
[05] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in Bluetooth

Review of attachment 8480611 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8480611 - Flags: review?(btian) → review+
Attachment #8480604 - Flags: review?(kyle) → review+
Comment on attachment 8480606 [details] [diff] [review]
[02] Bug 1059813: Use getter/setter methods of |UnixSocketRawData| in |KeyStore|

Review of attachment 8480606 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but :chucklee owns the keystore stuff so probably want him to have a look.
Attachment #8480606 - Flags: review?(kyle)
Attachment #8480606 - Flags: review?(chulee)
Attachment #8480606 - Flags: review+
Attachment #8480612 - Flags: review?(kyle) → review+
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #8)

> LGTM, but :chucklee owns the keystore stuff so probably want him to have a
> look.

Oh, thanks. I wasn't sure about keystore.

And thanks Chuck, for handling this so quickly.
Depends on: 1062754
Changes since v1:

  - rebased onto bug 1062754
Attachment #8480604 - Attachment is obsolete: true
Attachment #8485633 - Flags: review+
Changes since v1:

  - rebased onto bug 1062754
Attachment #8480612 - Attachment is obsolete: true
Attachment #8485635 - Flags: review+
You need to log in before you can comment on or make changes to this bug.